Skip to content

Conversation

@dybyte
Copy link
Contributor

@dybyte dybyte commented Nov 30, 2025

Purpose of this pull request

When stateProcess() inside updateJobState(JobStatus.PENDING) is executed as isRunning becomes true, the job state is updated to RUNNING. Later, startJob() sets the job state to SCHEDULED again before immediately transitioning it back to RUNNING, causing an unnecessary intermediate state change.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

I believe the existing tests already cover this change.

Check list

@github-actions github-actions bot added the Zeta label Nov 30, 2025
@dybyte dybyte marked this pull request as draft November 30, 2025 16:29
@dybyte dybyte changed the title [Fix][Zeta] Remove unnecessary job state update [Fix][Zeta] Fix unnecessary job state update Nov 30, 2025
@dybyte dybyte marked this pull request as ready for review November 30, 2025 16:49
}

public void startJob() {
public synchronized void startJob() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this duplicated with #10133

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is related, but I treated it as a separate concern from #10133.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After going through the details, I agree that such issues do exist.

Copy link
Contributor

@corgy-w corgy-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@corgy-w
Copy link
Contributor

corgy-w commented Dec 7, 2025

cc @zhangshenghang

Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit 349841e into apache:dev Dec 8, 2025
7 checks passed
@dybyte dybyte deleted the fix/job-state branch December 8, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants