Skip to content

[Fix][Zeta] Fix unnecessary job state update #10132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidzollo merged 2 commits into from
Dec 8, 2025
Merged

[Fix][Zeta] Fix unnecessary job state update #10132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a82297
[Fix][Zeta] Remove unnecessary job state update
dybyte Nov 30, 2025
a3175c2
[Fix][Zeta] Fix unnecessary job state update
dybyte Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ne-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/PhysicalPlan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ public void makeJobFailing(Throwable e) {
updateJobState(JobStatus.FAILING);
}

public void startJob() {
public synchronized void startJob() {
Copy link
Contributor

@LiJie20190102 LiJie20190102 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this duplicated with #10133

Copy link
Contributor Author

@dybyte dybyte Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is related, but I treated it as a separate concern from #10133.

Copy link
Contributor

@corgy-w corgy-w Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After going through the details, I agree that such issues do exist.

isRunning = true;
log.info("{} state process is start", getJobFullName());
updateJobState(JobStatus.SCHEDULED);
Expand Down