[Improve][Connector] Replace printStackTrace with proper logging #10176
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves code quality by replacing printStackTrace() calls with proper SLF4J logging in connector modules. Changes: - GraphQLWebSocket: Replaced 3 printStackTrace() calls with log.error() - ActivemqClient: Replaced 1 printStackTrace() call with log.error() - SlsSinkWriter: Replaced 1 printStackTrace() call with log.error() Additional improvements: - Added proper interrupt handling for InterruptedException - Ensured exception stack traces are properly logged via SLF4J Benefits: 1. Better production logging - stack traces go to log files instead of stderr 2. Consistent with project logging standards 3. Easier to debug issues in production environments 4. Follows Java best practices for exception handling
dybyte
reviewed
Dec 10, 2025
...n/java/org/apache/seatunnel/connectors/seatunnel/graphql/source/reader/GraphQLWebSocket.java
Outdated
Show resolved
Hide resolved
FuYouJ
approved these changes
Dec 16, 2025
…ache/seatunnel/connectors/seatunnel/graphql/source/reader/GraphQLWebSocket.java Co-authored-by: dy102 <[email protected]>
zhangshenghang
requested changes
Dec 16, 2025
Member
zhangshenghang
left a comment
zhangshenghang
left a comment
There was a problem hiding this comment.
don't delete .idea/vcs.xml
Contributor
Author
Thanks I have restored .idea/vcs.xml file |
zhangshenghang
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves code quality by replacing printStackTrace() calls with proper SLF4J logging in connector modules.
Changes:
Additional improvements:
Benefits:
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
incompatible-changes.mdto describe the incompatibility caused by this PR.