Skip to content

[Improve][Connector] Replace printStackTrace with proper logging #10176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhangshenghang merged 5 commits into from
Dec 17, 2025
+9 −8
Merged

[Improve][Connector] Replace printStackTrace with proper logging #10176

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2884e4e
[Improve][Connector] Replace printStackTrace with proper logging
Dec 10, 2025
6029faf
Merge branch 'apache:dev' into fix/replace-printstacktrace-with-logging
mengxpgogogo-eng Dec 16, 2025
73e8ad7
chore: trigger CI checks
Dec 16, 2025
ebcfc79
Update seatunnel-connectors-v2/connector-graphql/src/main/java/org/ap…
davidzollo Dec 16, 2025
64821bf
fix: restore .idea/vcs.xml file as requested by reviewer
Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...c/main/java/org/apache/seatunnel/connectors/seatunnel/activemq/client/ActivemqClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,11 @@ public ActivemqClient(ReadonlyConfig config) {
log.info("connection created");

} catch (Exception e) {
e.printStackTrace();
log.error("Error while creating AMQ client", e);
throw new ActivemqConnectorException(
ActivemqConnectorErrorCode.CREATE_ACTIVEMQ_CLIENT_FAILED,
"Error while create AMQ client ");
"Error while create AMQ client ",
e);
}
}

Expand Down
9 changes: 5 additions & 4 deletions ...ava/org/apache/seatunnel/connectors/seatunnel/graphql/source/reader/GraphQLWebSocket.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,7 @@ public void onClosing(@NotNull WebSocket webSocket, int code, @NotNull String re
@Override
public void onFailure(
@NotNull WebSocket webSocket, @NotNull Throwable t, @Nullable Response response) {
log.error("WebSocket connection failed: " + t.getMessage());
t.printStackTrace();
log.error("WebSocket connection failed: " + t.getMessage(), t);
scheduleReconnect();
}

Expand All @@ -108,7 +107,8 @@ public void onMessage(@NotNull WebSocket webSocket, @NotNull String text) {
try {
buffer.put(text);
} catch (InterruptedException e) {
e.printStackTrace();
log.error("Failed to put message into buffer", e);
Thread.currentThread().interrupt();
}
}

Expand Down Expand Up @@ -139,7 +139,8 @@ private void scheduleReconnect() {
Thread.sleep(RETRY_DELAY_MS);
connect();
} catch (InterruptedException e) {
e.printStackTrace();
log.error("Reconnection attempt interrupted", e);
Thread.currentThread().interrupt();
}
})
.start();
Expand Down
3 changes: 1 addition & 2 deletions ...r-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/sink/SlsSinkWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,7 @@ public void write(SeaTunnelRow element) throws IOException {
try {
this.client.PutLogs(plr);
} catch (Throwable e) {
log.error("write logs failed", e);
e.printStackTrace();
log.error("Failed to write logs to SLS", e);
throw new IOException(e);
}
}
Expand Down