[SPARK-12436][SQL] Now InferSchema should return NullType and ArrayType(NullType) #10474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArrayType(NullType)
|
Can one of the admins verify this patch? |
Contributor
|
cc @yhuai |
Contributor
There was a problem hiding this comment.
I think you can just delete this case.
Contributor
Author
There was a problem hiding this comment.
@yhuai Now removed NullType case as suggested.
Contributor
|
@naveenminchu I think the next step is to remove those null type fields before we write data to parquet/orc. @liancheng Parquet does not have a null type, right? |
Contributor
|
Can you add tests and also make changes to the write path (parquet/orc)? Otherwise, when you write a json dataset with null type to parquet, it will fail. |
Contributor
|
Is this PR really meant to modify 1,320 files? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a.) Currently I have fix for InferSchema to return NullType and ArrayType(NullType)
b.) @rxin Can you confirm second task on [SPARK-12346] is talking about
prepareJobForWrite(job: Job) in "/spark-sql_2.10/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRelation.scala"