Skip to content

Conversation

@vanzin
Copy link
Contributor

@vanzin vanzin commented Aug 4, 2016

Closing the following PRs due to requests or unresponsive users.

Closes #13923
Closes #14462
Closes #13123
Closes #14423 (requested by srowen)
Closes #14424 (requested by srowen)
Closes #14101 (requested by jkbradley)
Closes #10676 (requested by srowen)
Closes #10943 (requested by yhuai)
Closes #9936
Closes #10701

Closing the following PRs due to requests or unresponsive users.

Closes apache#13923
Closes apache#14462
Closes apache#13123
Closes apache#14423 (requested by srowen)
Closes apache#14424 (requested by srowen)
Closes apache#14101 (requested by jkbradley)
Closes apache#10676 (requested by srowen)
Closes apache#10943 (requested by yhuai)
Closes apache#9936
Closes apache#10701
@vanzin
Copy link
Contributor Author

vanzin commented Aug 4, 2016

Let me know if there are any concerns.

@vanzin
Copy link
Contributor Author

vanzin commented Aug 4, 2016

Also going to add #10474.

@vanzin
Copy link
Contributor Author

vanzin commented Aug 4, 2016

Adding #13248

@vanzin
Copy link
Contributor Author

vanzin commented Aug 4, 2016

Adding #14347

@vanzin
Copy link
Contributor Author

vanzin commented Aug 4, 2016

Adding #10356

@vanzin
Copy link
Contributor Author

vanzin commented Aug 4, 2016

Adding #9866

@SparkQA
Copy link

SparkQA commented Aug 4, 2016

Test build #63230 has finished for PR 14495 at commit 72cba51.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Aug 4, 2016

Does just mentioning the numbers in comments cause them to close when this merges? I wasn't sure whether the bot or Github looks for "closes ...".

Here are some more on my list:

Closes #14310
Closes #14347
Closes #14390
Closes #14343
Closes #14402
Closes #14437
Closes #14232
Closes #12000
Closes #13248
Closes #10270

@vanzin
Copy link
Contributor Author

vanzin commented Aug 4, 2016

No, just mentioning in comments doesn't work. I'm adding the "Closes #foo" text to the commit message I'll push, and at that time github will close them.

I'll look at adding the ones on your list.

@vanzin
Copy link
Contributor Author

vanzin commented Aug 4, 2016

I'll let 10270 since the submitter is active (I'll let him close the PR if he can't fix it). I'll take a look at 14232 since I've played with that code (it's just a comment anyway).

@vanzin
Copy link
Contributor Author

vanzin commented Aug 4, 2016

Alright, commit is pushed, lots of PRs are in the process of being closed.

@vanzin vanzin closed this Aug 4, 2016
@vanzin vanzin deleted the github-cleanup branch August 5, 2016 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants