[SPARK-10359][PROJECT-INFRA] Multiple fixes to dev/test-dependencies.sh script #10543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Actually, it occurred to me that I should really be setting |
|
Test build #48561 has finished for PR 10543 at commit
|
Contributor
Author
|
The latest test run passed the build tests and I manually tested this on the AMP Jenkins workers, so I'm going to speculatively merge this and will re-test the failing PRs. If that doesn't work, I'll hotfix to disable this test pending real investigation. |
|
Test build #48562 has finished for PR 10543 at commit
|
JoshRosen
added a commit
to JoshRosen/spark
that referenced
this pull request
Jan 10, 2016
…sh script This patch includes multiple fixes for the `dev/test-dependencies.sh` script (which was introduced in apache#10461): - Use `build/mvn --force` instead of `mvn` in one additional place. - Explicitly set a zero exit code on success. - Set `LC_ALL=C` to make `sort` results agree across machines (see https://stackoverflow.com/questions/28881/). - Set `should_run_build_tests=True` for `build` module (this somehow got lost). Author: Josh Rosen <[email protected]> Closes apache#10543 from JoshRosen/dep-script-fixes.
JoshRosen
added a commit
to JoshRosen/spark
that referenced
this pull request
Jan 10, 2016
…sh script This patch includes multiple fixes for the `dev/test-dependencies.sh` script (which was introduced in apache#10461): - Use `build/mvn --force` instead of `mvn` in one additional place. - Explicitly set a zero exit code on success. - Set `LC_ALL=C` to make `sort` results agree across machines (see https://stackoverflow.com/questions/28881/). - Set `should_run_build_tests=True` for `build` module (this somehow got lost). Author: Josh Rosen <[email protected]> Closes apache#10543 from JoshRosen/dep-script-fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch includes multiple fixes for the
dev/test-dependencies.shscript (which was introduced in #10461):build/mvn --forceinstead ofmvnin one additional place.LC_ALL=Cto makesortresults agree across machines (see https://stackoverflow.com/questions/28881/).should_run_build_tests=Trueforbuildmodule (this somehow got lost).