Skip to content

[SPARK-10359][PROJECT-INFRA] Multiple fixes to dev/test-dependencies.sh script #10543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshRosen wants to merge 8 commits into from
Closed

[SPARK-10359][PROJECT-INFRA] Multiple fixes to dev/test-dependencies.sh script #10543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
38da65f
Use our own MVN script
JoshRosen Jan 1, 2016
bf92b03
Set explicit zero exit code on success
JoshRosen Jan 1, 2016
ee489ef
Split complex pipeline across multiple lines
JoshRosen Jan 1, 2016
40aa7a1
Use LC_ALL=C for portability
JoshRosen Jan 1, 2016
abae307
Revert "Use LC_ALL=C for portability"
JoshRosen Jan 1, 2016
48867f9
Revert "Split complex pipeline across multiple lines"
JoshRosen Jan 1, 2016
1844d32
Set LC_ALL=C at top of script
JoshRosen Jan 1, 2016
58142e0
Set should_run_build_tests=True for build module
JoshRosen Jan 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dev/sparktestsupport/modules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,8 @@ def contains_file(self, filename):
source_file_regexes=[
".*pom.xml",
"dev/test-dependencies.sh",
]
],
should_run_build_tests=True
)

ec2 = Module(
Expand Down
8 changes: 7 additions & 1 deletion dev/test-dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ set -e
FWDIR="$(cd "`dirname $0`"/..; pwd)"
cd "$FWDIR"

# Explicitly set locale in order to make `sort` output consistent across machines.
# See https://stackoverflow.com/questions/28881 for more details.
export LC_ALL=C

# TODO: This would be much nicer to do in SBT, once SBT supports Maven-style resolution.

# NOTE: These should match those in the release publishing script
Expand All @@ -37,7 +41,7 @@ HADOOP_PROFILES=(
# resolve Spark's internal submodule dependencies.

# See http://stackoverflow.com/a/3545363 for an explanation of this one-liner:
OLD_VERSION=$(mvn help:evaluate -Dexpression=project.version|grep -Ev '(^\[|Download\w+:)')
OLD_VERSION=$($MVN help:evaluate -Dexpression=project.version|grep -Ev '(^\[|Download\w+:)')
TEMP_VERSION="spark-$(date +%s | tail -c6)"

function reset_version {
Expand Down Expand Up @@ -100,3 +104,5 @@ for HADOOP_PROFILE in "${HADOOP_PROFILES[@]}"; do
exit 1
fi
done

exit 0