Skip to content

[SPARK-12692][BUILD] Scala style: check no white space before comma and colon #10643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sarutak wants to merge 1 commit into from
Closed

[SPARK-12692][BUILD] Scala style: check no white space before comma and colon #10643

sarutak wants to merge 1 commit into from

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Jan 7, 2016

We should not put a white space before , and : so let's check it.
Because there are lots of style violations, first, I'd like to add a checker, enable and let the level warning.
Then, I'd like to fix the style step by step.

@SparkQA
Copy link

SparkQA commented Jan 7, 2016

Test build #48932 has finished for PR 10643 at commit e7f3210.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak
Copy link
Member Author

sarutak commented Jan 7, 2016

retest this please.

@SparkQA
Copy link

SparkQA commented Jan 7, 2016

Test build #48942 has finished for PR 10643 at commit e7f3210.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak
Copy link
Member Author

sarutak commented Jan 7, 2016

I believe the latest test failure is not related to this change.

@sarutak
Copy link
Member Author

sarutak commented Jan 7, 2016

retest this please.

@SparkQA
Copy link

SparkQA commented Jan 7, 2016

Test build #48948 has finished for PR 10643 at commit e7f3210.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jan 7, 2016

Can you paste some of the warnings?

@sarutak
Copy link
Member Author

sarutak commented Jan 8, 2016

warnings are displayed like as follows.

[warn] /home/sarutak/work/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala:125:29: Space before token ,
[warn] /home/sarutak/work/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala:52:20: Space before token :
[warn] /home/sarutak/work/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala:119:23: Space before token :
[warn] /home/sarutak/work/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala:389:22: Space before token :
[warn] /home/sarutak/work/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala:206:39: Space before token ,

@rxin
Copy link
Contributor

rxin commented Jan 8, 2016

OK this looks good. Would you have time to fix the issues too?

@sarutak
Copy link
Member Author

sarutak commented Jan 8, 2016

Yes I'll do it. Should I fix the style issues in this change?
I was going to fix in another PR.

@rxin
Copy link
Contributor

rxin commented Jan 8, 2016

Another PR is fine. I'm going to merge this.

@asfgit asfgit closed this in 794ea55 Jan 8, 2016
This was referenced Jan 10, 2016
Closed
Closed
Closed
Closed
ghost pushed a commit to dbtsai/spark that referenced this pull request Jan 10, 2016
@sarutak @rxin
[SPARK-12692][BUILD][MLLIB] Scala style: Fix the style violation (Spa…
e5904bb 
…ce before "," or ":")

Fix the style violation (space before , and :).
This PR is a followup for apache#10643.

Author: Kousuke Saruta <[email protected]>

Closes apache#10684 from sarutak/SPARK-12692-followup-mllib.
asfgit pushed a commit that referenced this pull request Jan 10, 2016
@sarutak @rxin
[SPARK-12692][BUILD][GRAPHX] Scala style: Fix the style violation (Sp…
3119206 
…ace before "," or ":")

Fix the style violation (space before `,` and `:`).
This PR is a followup for #10643.

Author: Kousuke Saruta <[email protected]>

Closes #10683 from sarutak/SPARK-12692-followup-graphx.
@sarutak sarutak mentioned this pull request Jan 12, 2016
Closed
asfgit pushed a commit that referenced this pull request Jan 12, 2016
@sarutak @rxin
[SPARK-12692][BUILD][STREAMING] Scala style: Fix the style violation …
39ae04e 
…(Space before "," or ":")

Fix the style violation (space before , and :).
This PR is a followup for #10643.

Author: Kousuke Saruta <[email protected]>

Closes #10685 from sarutak/SPARK-12692-followup-streaming.
asfgit pushed a commit that referenced this pull request Jan 12, 2016
@sarutak @rxin
[SPARK-12692][BUILD][YARN] Scala style: Fix the style violation (Spac…
112abf9 
…e before "," or ":")

Fix the style violation (space before , and :).
This PR is a followup for #10643.

Author: Kousuke Saruta <[email protected]>

Closes #10686 from sarutak/SPARK-12692-followup-yarn.
@sarutak sarutak mentioned this pull request Jan 12, 2016
Closed
asfgit pushed a commit that referenced this pull request Jan 12, 2016
@sarutak @rxin
[SPARK-12692][BUILD][SQL] Scala style: Fix the style violation (Space…
8cfa218 
… before "," or ":")

Fix the style violation (space before , and :).
This PR is a followup for #10643.

Author: Kousuke Saruta <[email protected]>

Closes #10718 from sarutak/SPARK-12692-followup-sql.
@sarutak sarutak mentioned this pull request Jan 13, 2016
Closed
asfgit pushed a commit that referenced this pull request Jan 13, 2016
@sarutak @rxin
[SPARK-12692][BUILD][CORE] Scala style: Fix the style violation (Spac…
f14922c 
…e before ",")

Fix the style violation (space before , and :).
This PR is a followup for #10643

Author: Kousuke Saruta <[email protected]>

Closes #10719 from sarutak/SPARK-12692-followup-core.
asfgit pushed a commit that referenced this pull request Jan 13, 2016
@sarutak @rxin
[SPARK-12692][BUILD][SQL] Scala style: Fix the style violation (Space…
cb7b864 
… before ",")

Fix the style violation (space before , and :).
This PR is a followup for #10643 and rework of #10685 .

Author: Kousuke Saruta <[email protected]>

Closes #10732 from sarutak/SPARK-12692-followup-sql.
@sarutak sarutak deleted the SPARK-12692 branch June 4, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarutak @SparkQA @rxin