Skip to content

[SPARK-12692][BUILD][GRAPHX] Scala style: Fix the style violation (Space before "," or ":") #10683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sarutak wants to merge 1 commit into from
Closed

[SPARK-12692][BUILD][GRAPHX] Scala style: Fix the style violation (Space before "," or ":") #10683

sarutak wants to merge 1 commit into from

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Jan 10, 2016

Fix the style violation (space before , and :).
This PR is a followup for #10643.

sarutak
sarutak reviewed Jan 10, 2016
View reviewed changes
graphx/src/main/scala/org/apache/spark/graphx/impl/ReplicatedVertexView.scala
Copy link
Member Author

@sarutak sarutak Jan 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed we need a white space if the name of variables ends with _.
Those variables might be used internally so can we rename to which like prepended _ right?

Copy link
Contributor

@rxin rxin Jan 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@SparkQA
Copy link

SparkQA commented Jan 10, 2016

Test build #49062 has finished for PR 10683 at commit caced69.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak
Copy link
Member Author

sarutak commented Jan 10, 2016

retest this please.

@SparkQA
Copy link

SparkQA commented Jan 10, 2016

Test build #49065 has finished for PR 10683 at commit caced69.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak
Copy link
Member Author

sarutak commented Jan 10, 2016

MiMa said

[error] (streaming-mqtt/*:mimaPreviousClassfiles) sbt.ResolveException: unresolved dependency: org.eclipse.paho#org.eclipse.paho.client.mqttv3;1.0.1: not found

But It's funny. I think the dependency of streaming-mqtt is not related to this change.

@sarutak
Copy link
Member Author

sarutak commented Jan 10, 2016

retest this please.

@rxin
Copy link
Contributor

rxin commented Jan 10, 2016

LGTM

@SparkQA
Copy link

SparkQA commented Jan 10, 2016

Test build #2360 has finished for PR 10683 at commit caced69.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak sarutak mentioned this pull request Jan 10, 2016
Closed
@sarutak
Copy link
Member Author

sarutak commented Jan 10, 2016

retest this please.

@SparkQA
Copy link

SparkQA commented Jan 10, 2016

Test build #49075 has finished for PR 10683 at commit caced69.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jan 10, 2016

I've merged this.

@asfgit asfgit closed this in 3119206 Jan 10, 2016
@sarutak sarutak mentioned this pull request Jan 11, 2016
Closed
@sarutak sarutak deleted the SPARK-12692-followup-graphx branch June 4, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarutak @SparkQA @rxin