Skip to content

[SPARK-16318][SQL] Implement all remaining xpath functions (branch-2.0) #14131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petermaxlee wants to merge 2 commits into from
Closed

[SPARK-16318][SQL] Implement all remaining xpath functions (branch-2.0) #14131

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d6f654
[SPARK-16318][SQL] Implement all remaining xpath functions
petermaxlee Jul 11, 2016
ce53833
[SPARK-16436][SQL] checkEvaluation should support NaN
petermaxlee Jul 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[SPARK-16436][SQL] checkEvaluation should support NaN 
## What changes were proposed in this pull request?
This small patch modifies ExpressionEvalHelper. checkEvaluation to support comparing NaN values for floating point comparisons.

## How was this patch tested?
This is a test harness change.

Author: petermaxlee <[email protected]>

Closes #14103 from petermaxlee/SPARK-16436.
  • Loading branch information
@petermaxlee
petermaxlee committed Jul 11, 2016
commit ce538330840cd97da169290759aa951f87e44ded
4 changes: 4 additions & 0 deletions ...alyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ trait ExpressionEvalHelper extends GeneratorDrivenPropertyChecks {
expected.asInstanceOf[Spread[Double]].isWithin(result)
case (result: MapData, expected: MapData) =>
result.keyArray() == expected.keyArray() && result.valueArray() == expected.valueArray()
case (result: Double, expected: Double) =>
if (expected.isNaN) result.isNaN else expected == result
case (result: Float, expected: Float) =>
if (expected.isNaN) result.isNaN else expected == result
case _ =>
result == expected
}
Expand Down