-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-16508][SparkR] Fix warnings on undocumented/duplicated arguments by CRAN-check #14558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
82e2f09
41d9dca
44115e9
2d136db
901edbb
475ee38
2285de7
20efb79
719ac5f
15637f7
977fbbf
d3a30d2
1e40135
8611bc2
51b1016
ea8a198
4b434e7
0ed6236
33a213f
b87ba8f
6bf20cd
bc683f0
0fb0149
d2c1d64
b4047fc
bde94cd
38378f5
a21ecc9
750f880
e02d0d0
8f4cacd
4503632
e5771a1
2e2c787
237ae54
1c56971
022230c
6cb3eab
3e0163b
68a24d3
22c7660
394d598
9406f82
585d1d9
91aa532
5735b8b
ec5f157
0bc3753
6d5233e
0edfd7d
e72a6aa
afa69ed
c9cfe43
3aafaa7
315a0dd
aa3d233
71170e9
2682719
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -354,8 +354,8 @@ setMethod("spark.kmeans", signature(data = "SparkDataFrame", formula = "formula" | |
| #' Note: A saved-loaded model does not support this method. | ||
| #' | ||
| #' @param object a fitted k-means model. | ||
| #' @param method type of fitted results, `"centers"` for cluster centers | ||
| #' or `"classes"` for assigned classes. | ||
| #' @param method type of fitted results, \code{"centers"} for cluster centers | ||
| #' or \code{"classes"} for assigned classes. | ||
| #' @param ... additional argument(s) passed to the method. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's remove
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The same as above... |
||
| #' @return \code{fitted} returns a SparkDataFrame containing fitted values. | ||
| #' @rdname fitted | ||
|
|
@@ -428,8 +428,8 @@ setMethod("predict", signature(object = "KMeansModel"), | |
| #' @param data a \code{SparkDataFrame} of observations and labels for model fitting. | ||
| #' @param formula a symbolic description of the model to be fitted. Currently only a few formula | ||
| #' operators are supported, including '~', '.', ':', '+', and '-'. | ||
| #' @param ... additional argument(s) passed to the method. Currently only \code{smoothing}. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is removed, right?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is actually for the generic function. Should I move these doc to the generic definition? |
||
| #' @param smoothing smoothing parameter. | ||
| #' @param ... additional parameter(s) passed to the method. | ||
| #' @return \code{spark.naiveBayes} returns a fitted naive Bayes model. | ||
| #' @rdname spark.naiveBayes | ||
| #' @aliases spark.naiveBayes,SparkDataFrame,formula-method | ||
|
|
@@ -457,7 +457,7 @@ setMethod("predict", signature(object = "KMeansModel"), | |
| #' } | ||
| #' @note spark.naiveBayes since 2.0.0 | ||
| setMethod("spark.naiveBayes", signature(data = "SparkDataFrame", formula = "formula"), | ||
| function(data, formula, smoothing = 1.0, ...) { | ||
| function(data, formula, smoothing = 1.0) { | ||
| formula <- paste(deparse(formula), collapse = "") | ||
| jobj <- callJStatic("org.apache.spark.ml.r.NaiveBayesWrapper", "fit", | ||
| formula, data@sdf, smoothing) | ||
|
|
@@ -577,8 +577,7 @@ read.ml <- function(path) { | |
| #' @param data a SparkDataFrame for training. | ||
| #' @param formula a symbolic description of the model to be fitted. Currently only a few formula | ||
| #' operators are supported, including '~', ':', '+', and '-'. | ||
| #' Note that operator '.' is not supported currently | ||
| #' @param ... additional argument(s) passed to the method. | ||
| #' Note that operator '.' is not supported currently. | ||
| #' @return \code{spark.survreg} returns a fitted AFT survival regression model. | ||
| #' @rdname spark.survreg | ||
| #' @seealso survival: \url{https://cran.r-project.org/web/packages/survival/} | ||
|
|
@@ -603,7 +602,7 @@ read.ml <- function(path) { | |
| #' } | ||
| #' @note spark.survreg since 2.0.0 | ||
| setMethod("spark.survreg", signature(data = "SparkDataFrame", formula = "formula"), | ||
| function(data, formula, ...) { | ||
| function(data, formula) { | ||
| formula <- paste(deparse(formula), collapse = "") | ||
| jobj <- callJStatic("org.apache.spark.ml.r.AFTSurvivalRegressionWrapper", | ||
| "fit", formula, data@sdf) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the singular form is property and plural is properties, so the
()doesn't really work in this case. let's just leave it as properties.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks!