[SPARK-18575][WEB] Keep same style: adjust the position of driver log links #16001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncleGen
changed the title
|
Test build #69117 has started for PR 16001 at commit |
srowen
reviewed
Nov 24, 2016
| driverLogs = Some(Map( | ||
| "stderr" -> s"$baseUrl/stderr?start=-4096", | ||
| "stdout" -> s"$baseUrl/stdout?start=-4096")) | ||
| "stdout" -> s"$baseUrl/stdout?start=-4096", |
Member
There was a problem hiding this comment.
Explain please what this is trying to be consistent with?
Contributor
Author
There was a problem hiding this comment.
executor log link order: stdout then stderr
but, the driver log link order: stderr then stdout
After PR:
Frankly, it is just a picky issue.
Contributor
Author
|
retest this please |
|
Test build #69123 has finished for PR 16001 at commit
|
Member
|
Not sure this is worth a whole commit, but it is probably good to fix. LGTM. |
Contributor
Author
|
@srowen waiting for your feedback :D |
Member
|
Merged to master/2.1 |
asfgit
pushed a commit
that referenced
this pull request
Nov 25, 2016
… links ## What changes were proposed in this pull request? NOT BUG, just adjust the position of driver log link to keep the same style with other executors log link.  ## How was this patch tested? no Author: uncleGen <[email protected]> Closes #16001 from uncleGen/SPARK-18575. (cherry picked from commit f58a8aa) Signed-off-by: Sean Owen <[email protected]>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 2, 2016
… links ## What changes were proposed in this pull request? NOT BUG, just adjust the position of driver log link to keep the same style with other executors log link.  ## How was this patch tested? no Author: uncleGen <[email protected]> Closes apache#16001 from uncleGen/SPARK-18575.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
… links ## What changes were proposed in this pull request? NOT BUG, just adjust the position of driver log link to keep the same style with other executors log link.  ## How was this patch tested? no Author: uncleGen <[email protected]> Closes apache#16001 from uncleGen/SPARK-18575.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
NOT BUG, just adjust the position of driver log link to keep the same style with other executors log link.
How was this patch tested?
no