Skip to content

[SPARK-18575][WEB] Keep same style: adjust the position of driver log links #16001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uncleGen wants to merge 1 commit into from
Closed

[SPARK-18575][WEB] Keep same style: adjust the position of driver log links #16001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClusterSchedulerBackend.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ private[spark] class YarnClusterSchedulerBackend(
val baseUrl = s"$httpScheme$httpAddress/node/containerlogs/$containerId/$user"
logDebug(s"Base URL for logs: $baseUrl")
driverLogs = Some(Map(
"stderr" -> s"$baseUrl/stderr?start=-4096",
"stdout" -> s"$baseUrl/stdout?start=-4096"))
"stdout" -> s"$baseUrl/stdout?start=-4096",
Copy link
Member

@srowen srowen Nov 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain please what this is trying to be consistent with?

Copy link
Contributor Author

@uncleGen uncleGen Nov 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

executor log link order: stdout then stderr
but, the driver log link order: stderr then stdout

After PR:

image

Frankly, it is just a picky issue.

"stderr" -> s"$baseUrl/stderr?start=-4096"))
} catch {
case e: Exception =>
logInfo("Error while building AM log links, so AM" +
Expand Down