Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SPARK-19320][MESOS][WIP]allow specifying a hard limit on number of gpus required in each spark executor when running on mesos #17235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
[SPARK-19320][MESOS][WIP]allow specifying a hard limit on number of gpus required in each spark executor when running on mesos #17235
Changes from 1 commit
b14bfc3b938438bca4259044f7ecffc57b02e1fd46ceaf77a504e62e540855399a9473924c424a7b430bc5f1cc3ec68d8f095d1cba4293c2fbe42168ddf0d27536e28fb036c498b41ec35e5ae4e090f3ca888fedad935f586d251c24f09b301ff035e5fee3e007556233ea908b0a1e9307fd94ed4f10cb321b4f01f81ddaf654b3974aa0dfe468a96702d85a608bf30773754b353787671a8e9d4fea78463824b239e303add6d55dbdc605646c574955bea56c6f62c5b91873dc5a31d1b2ebadfd95e4d90332063592f5c80368eb9760c8d048d760de2b3d233476799c9e6035a750a59eb00378fd648bfad2904005a4514b3c572a8765bc12eaf4f3e9f9715776a2c090264ac8a272dd5280d93f44c8a831345fdc8f12190bc7a90387565c67eef470a7f5f2caf392057e1da3df58a957a365257fecf51dbb06c666dd5b899c6cf9a277ae82ba1eba66636efb4724dbb58cf77ba766627633933561e9cc85c6ce626ac2cea4aa466039e32c606432a01c999e823bacab90bf527fe8249e3c816059e3a568c911ad733b81b5d71f3debff51977bcd77814a61ab28c3bcadd9d1bee694cd70f1bcdd228cd04d99b951ee494dae3df4e661304680e9cf1a355b66f0169a16b44c4dab305906fc6cf82b2dd08af726cd259860d943a684d20a97690d77e9afb21bf86174eae300a5ab1e639a13f47dcef3df91b946f316235132db2fb8416fab6b7f96f2d27f543b527fc5d6b9e49d13eb37c02bbe73fc472bdb8302cc9c36aa2f21897f57b6470c5dceb8bfc8c790d16faa4411ac737cdf075773ab19064f1bb9ad2d141439fdbd57882b31648c5d75b14b433acacafca5463d90e737f963a88e6d752cf83c47087e01500436b1f73d35f53a8202269155c24bdaa42cc6d12fdaeb50f820e2155266558518d0aeb2ecc829cd7b2abfee1b952b44807942410b00abbe53a78b8733e00d00c76714811d181261af561a76d099f4125ee8161b85bcdac1ab6bf79aa28c0189ab771abeb3d2131aa90c5cda819dab0ef16bd804949cca4625ea4cbf26b512233789bdbe76e4a55fcb88f95c2c4dcaf8b6cc8ddbc430698e6c65accb8b4c99f48c67aa73aa4e467144b5104901dd609ba5f2b36eb6c8da535888b84aaf40bb1720708cfc8a2b6b23693354b4f2a92ea7fdb526f707d6ff390d3a631e3d2022b84ff7e3f98375c2c1c5bc5c5c37ba87b355ef2881c301f3d7a07742File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
…inst project's code style ## What changes were proposed in this pull request? Currently, multi-dot separated variables in R is not allowed. For example, ```diff setMethod("from_json", signature(x = "Column", schema = "structType"), - function(x, schema, asJsonArray = FALSE, ...) { + function(x, schema, as.json.array = FALSE, ...) { if (asJsonArray) { jschema <- callJStatic("org.apache.spark.sql.types.DataTypes", "createArrayType", ``` produces an error as below: ``` R/functions.R:2462:31: style: Words within variable and function names should be separated by '_' rather than '.'. function(x, schema, as.json.array = FALSE, ...) { ^~~~~~~~~~~~~ ``` This seems against https://google.github.io/styleguide/Rguide.xml#identifiers which says > The preferred form for variable names is all lower case letters and words separated with dots This looks because lintr by default https://github.com/jimhester/lintr follows http://r-pkgs.had.co.nz/style.html as written in the README.md. Few cases seems not following Google's one as "a few tweaks". Per [SPARK-6813](https://issues.apache.org/jira/browse/SPARK-6813), we follow Google's R Style Guide with few exceptions https://google.github.io/styleguide/Rguide.xml. This is also merged into Spark's website - apache/spark-website#43 Also, it looks we have no limit on function name. This rule also looks affecting to the name of functions as written in the README.md. > `multiple_dots_linter`: check that function and variable names are separated by _ rather than .. ## How was this patch tested? Manually tested `./dev/lint-r`with the manual change below in `R/functions.R`: ```diff setMethod("from_json", signature(x = "Column", schema = "structType"), - function(x, schema, asJsonArray = FALSE, ...) { + function(x, schema, as.json.array = FALSE, ...) { if (asJsonArray) { jschema <- callJStatic("org.apache.spark.sql.types.DataTypes", "createArrayType", ``` **Before** ```R R/functions.R:2462:31: style: Words within variable and function names should be separated by '_' rather than '.'. function(x, schema, as.json.array = FALSE, ...) { ^~~~~~~~~~~~~ ``` **After** ``` lintr checks passed. ``` Author: hyukjinkwon <[email protected]> Closes #17590 from HyukjinKwon/disable-dot-in-name.Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing