Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SPARK-19320][MESOS][WIP]allow specifying a hard limit on number of gpus required in each spark executor when running on mesos #17235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
[SPARK-19320][MESOS][WIP]allow specifying a hard limit on number of gpus required in each spark executor when running on mesos #17235
Changes from 1 commit
b14bfc3b938438bca4259044f7ecffc57b02e1fd46ceaf77a504e62e540855399a9473924c424a7b430bc5f1cc3ec68d8f095d1cba4293c2fbe42168ddf0d27536e28fb036c498b41ec35e5ae4e090f3ca888fedad935f586d251c24f09b301ff035e5fee3e007556233ea908b0a1e9307fd94ed4f10cb321b4f01f81ddaf654b3974aa0dfe468a96702d85a608bf30773754b353787671a8e9d4fea78463824b239e303add6d55dbdc605646c574955bea56c6f62c5b91873dc5a31d1b2ebadfd95e4d90332063592f5c80368eb9760c8d048d760de2b3d233476799c9e6035a750a59eb00378fd648bfad2904005a4514b3c572a8765bc12eaf4f3e9f9715776a2c090264ac8a272dd5280d93f44c8a831345fdc8f12190bc7a90387565c67eef470a7f5f2caf392057e1da3df58a957a365257fecf51dbb06c666dd5b899c6cf9a277ae82ba1eba66636efb4724dbb58cf77ba766627633933561e9cc85c6ce626ac2cea4aa466039e32c606432a01c999e823bacab90bf527fe8249e3c816059e3a568c911ad733b81b5d71f3debff51977bcd77814a61ab28c3bcadd9d1bee694cd70f1bcdd228cd04d99b951ee494dae3df4e661304680e9cf1a355b66f0169a16b44c4dab305906fc6cf82b2dd08af726cd259860d943a684d20a97690d77e9afb21bf86174eae300a5ab1e639a13f47dcef3df91b946f316235132db2fb8416fab6b7f96f2d27f543b527fc5d6b9e49d13eb37c02bbe73fc472bdb8302cc9c36aa2f21897f57b6470c5dceb8bfc8c790d16faa4411ac737cdf075773ab19064f1bb9ad2d141439fdbd57882b31648c5d75b14b433acacafca5463d90e737f963a88e6d752cf83c47087e01500436b1f73d35f53a8202269155c24bdaa42cc6d12fdaeb50f820e2155266558518d0aeb2ecc829cd7b2abfee1b952b44807942410b00abbe53a78b8733e00d00c76714811d181261af561a76d099f4125ee8161b85bcdac1ab6bf79aa28c0189ab771abeb3d2131aa90c5cda819dab0ef16bd804949cca4625ea4cbf26b512233789bdbe76e4a55fcb88f95c2c4dcaf8b6cc8ddbc430698e6c65accb8b4c99f48c67aa73aa4e467144b5104901dd609ba5f2b36eb6c8da535888b84aaf40bb1720708cfc8a2b6b23693354b4f2a92ea7fdb526f707d6ff390d3a631e3d2022b84ff7e3f98375c2c1c5bc5c5c37ba87b355ef2881c301f3d7a07742File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
## What changes were proposed in this pull request? When reg == 0, MLOR has multiple solutions and we need to centralize the coeffs to get identical result. BUT current implementation centralize the `coefficientMatrix` by the global coeffs means. In fact the `coefficientMatrix` should be centralized on each feature index itself. Because, according to the MLOR probability distribution function, it can be proven easily that: suppose `{ w0, w1, .. w(K-1) }` make up the `coefficientMatrix`, then `{ w0 + c, w1 + c, ... w(K - 1) + c}` will also be the equivalent solution. `c` is an arbitrary vector of `numFeatures` dimension. reference https://core.ac.uk/download/pdf/6287975.pdf So that we need to centralize the `coefficientMatrix` on each feature dimension separately. **We can also confirm this through R library `glmnet`, that MLOR in `glmnet` always generate coefficients result that the sum of each dimension is all `zero`, when reg == 0.** ## How was this patch tested? Tests added. Author: WeichenXu <[email protected]> Closes #17706 from WeichenXu123/mlor_center.Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing