Skip to content

[SPARK-20863] Add metrics/instrumentation to LiveListenerBus #18083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshRosen wants to merge 12 commits into from
Closed

[SPARK-20863] Add metrics/instrumentation to LiveListenerBus #18083

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a1fb5a8
WIP
JoshRosen May 23, 2017
a46c247
Fix test compilation
JoshRosen May 24, 2017
378206e
Mock in EventLoggingListenerSuite
JoshRosen May 24, 2017
37a1a7d
Address Wenchen's review comments.
JoshRosen May 25, 2017
3b713a3
Add per-listener timing statistics.
JoshRosen May 25, 2017
60c7448
Protect against registering thousands of listener classes.
JoshRosen May 26, 2017
dcecdae
Merge remote-tracking branch 'origin/master' into listener-bus-metrics
JoshRosen Jun 5, 2017
4a083de
Minor cleanups.
JoshRosen Jun 5, 2017
d1a5e99
Add test for per-listener-class timer; rename method.
JoshRosen Jun 5, 2017
b8164b2
Merge remote-tracking branch 'origin/master' into listener-bus-metrics
JoshRosen Jun 8, 2017
f36fbaa
Use Option.
JoshRosen Jun 8, 2017
76b669c
Add configuration.
JoshRosen Jun 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add configuration.
  • Loading branch information
@JoshRosen
JoshRosen committed Jun 8, 2017
commit 76b669ca6eb35a0cce4291702baa5d1f60adb467
6 changes: 6 additions & 0 deletions core/src/main/scala/org/apache/spark/internal/config/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,12 @@ package object config {
.checkValue(_ > 0, "The capacity of listener bus event queue must not be negative")
.createWithDefault(10000)

private[spark] val LISTENER_BUS_METRICS_MAX_LISTENER_CLASSES_TIMED =
ConfigBuilder("spark.scheduler.listenerbus.metrics.maxListenerClassesTimed")
.internal()
.intConf
.createWithDefault(128)

// This property sets the root namespace for metrics reporting
private[spark] val METRICS_NAMESPACE = ConfigBuilder("spark.metrics.namespace")
.stringConf
Expand Down
11 changes: 7 additions & 4 deletions core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ private[spark] class LiveListenerBus(conf: SparkConf) extends SparkListenerBus {
private val eventQueue =
new LinkedBlockingQueue[SparkListenerEvent](conf.get(LISTENER_BUS_EVENT_QUEUE_CAPACITY))

private[spark] val metrics = new LiveListenerBusMetrics(eventQueue)
private[spark] val metrics = new LiveListenerBusMetrics(conf, eventQueue)

// Indicate if `start()` is called
private val started = new AtomicBoolean(false)
Expand Down Expand Up @@ -243,8 +243,11 @@ private[spark] object LiveListenerBus {
val name = "SparkListenerBus"
}

private[spark]
class LiveListenerBusMetrics(queue: LinkedBlockingQueue[_]) extends Source with Logging {
private[spark] class LiveListenerBusMetrics(
conf: SparkConf,
queue: LinkedBlockingQueue[_])
extends Source with Logging {

override val sourceName: String = "LiveListenerBus"
override val metricRegistry: MetricRegistry = new MetricRegistry

Expand Down Expand Up @@ -285,7 +288,7 @@ class LiveListenerBusMetrics(queue: LinkedBlockingQueue[_]) extends Source with
def getTimerForListenerClass(cls: Class[_ <: SparkListenerInterface]): Option[Timer] = {
synchronized {
val className = cls.getName
val maxTimed = 128
val maxTimed = conf.get(LISTENER_BUS_METRICS_MAX_LISTENER_CLASSES_TIMED)
perListenerClassTimers.get(className).orElse {
if (perListenerClassTimers.size == maxTimed) {
logError(s"Not measuring processing time for listener class $className because a " +
Expand Down