-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-20863] Add metrics/instrumentation to LiveListenerBus #18083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a1fb5a8
WIP
JoshRosen a46c247
Fix test compilation
JoshRosen 378206e
Mock in EventLoggingListenerSuite
JoshRosen 37a1a7d
Address Wenchen's review comments.
JoshRosen 3b713a3
Add per-listener timing statistics.
JoshRosen 60c7448
Protect against registering thousands of listener classes.
JoshRosen dcecdae
Merge remote-tracking branch 'origin/master' into listener-bus-metrics
JoshRosen 4a083de
Minor cleanups.
JoshRosen d1a5e99
Add test for per-listener-class timer; rename method.
JoshRosen b8164b2
Merge remote-tracking branch 'origin/master' into listener-bus-metrics
JoshRosen f36fbaa
Use Option.
JoshRosen 76b669c
Add configuration.
JoshRosen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add test for per-listener-class timer; rename method.
- Loading branch information
commit d1a5e991fb7fc3e7f93090c23d8088be8b650f61
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be configurable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shrug. Maybe, but note that this would be 128 separate listener classes. Let me put in an undocumented configuration.