Skip to content

[PySpark] [SPARK-2954] [SPARK-2948] [SPARK-2910] [SPARK-2101] Python 2.6 Fixes #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshRosen wants to merge 2 commits into from
Closed

[PySpark] [SPARK-2954] [SPARK-2948] [SPARK-2910] [SPARK-2101] Python 2.6 Fixes #1874

JoshRosen wants to merge 2 commits into from

Conversation

@JoshRosen
Copy link
Contributor

@JoshRosen JoshRosen commented Aug 10, 2014

  • Modify python/run-tests to test with Python 2.6
  • Use unittest2 when running on Python 2.6.
  • Fix issue with namedtuple.
  • Skip TestOutputFormat.test_newhadoop on Python 2.6 until SPARK-2951 is fixed.
  • Fix MLlib _deserialize_double on Python 2.6.

Closes #1868. Closes #1042.

@SparkQA
Copy link

SparkQA commented Aug 10, 2014

QA tests have started for PR 1874. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18274/consoleFull

@JoshRosen
[SPARK-2948] [SPARK-2910] [SPARK-2101] Python 2.6 fixes
5d18fd7 
- Modify python/run-tests to test with Python 2.6, if available.
- Use unittest2 when running on Python 2.6.
- Fix issue with namedtuple.
- Skip TestOutputFormat.test_newhadoop on Python 2.6 until SPARK-2951 is fixed.

Closes apache#1868.  Closes apache#1042.
@JoshRosen
[SPARK-2954] Fix MLlib _deserialize_double on Python 2.6.
983d259
@JoshRosen
Copy link
Contributor Author

JoshRosen commented Aug 10, 2014

Jenkins, test this please.

I installed unittest2 on Jenkins, so hopefully these tests should now pass with python2.6.

@SparkQA
Copy link

SparkQA commented Aug 10, 2014

QA tests have started for PR 1874. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18275/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 10, 2014

QA results for PR 1874:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18275/consoleFull

mateiz
mateiz reviewed Aug 10, 2014
View reviewed changes
python/pyspark/tests.py
Copy link
Contributor

@mateiz mateiz Aug 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this, does with on ZipFiles not work in 2.6?

Copy link
Contributor Author

@JoshRosen JoshRosen Aug 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, support for using ZipFile as a context manager was added in Python 2.7: https://docs.python.org/2.7/library/zipfile.html?highlight=zipfile#zipfile.ZipFile

Copy link
Contributor

@mateiz mateiz Aug 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, makes sense. Patch looks good to me otherwise -- feel free to merge it.

@JoshRosen
Copy link
Contributor Author

JoshRosen commented Aug 11, 2014

I've merged this into master and branch-1.1.

@asfgit asfgit closed this in db06a81 Aug 11, 2014
asfgit pushed a commit that referenced this pull request Aug 11, 2014
@JoshRosen
[PySpark] [SPARK-2954] [SPARK-2948] [SPARK-2910] [SPARK-2101] Python …
09b8a3c 
…2.6 Fixes

- Modify python/run-tests to test with Python 2.6
- Use unittest2 when running on Python 2.6.
- Fix issue with namedtuple.
- Skip TestOutputFormat.test_newhadoop on Python 2.6 until SPARK-2951 is fixed.
- Fix MLlib _deserialize_double on Python 2.6.

Closes #1868.  Closes #1042.

Author: Josh Rosen <[email protected]>

Closes #1874 from JoshRosen/python2.6 and squashes the following commits:

983d259 [Josh Rosen] [SPARK-2954] Fix MLlib _deserialize_double on Python 2.6.
5d18fd7 [Josh Rosen] [SPARK-2948] [SPARK-2910] [SPARK-2101] Python 2.6 fixes

(cherry picked from commit db06a81)
Signed-off-by: Josh Rosen <[email protected]>
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@JoshRosen @conviva-zz
[PySpark] [SPARK-2954] [SPARK-2948] [SPARK-2910] [SPARK-2101] Python …
a878803 
…2.6 Fixes

- Modify python/run-tests to test with Python 2.6
- Use unittest2 when running on Python 2.6.
- Fix issue with namedtuple.
- Skip TestOutputFormat.test_newhadoop on Python 2.6 until SPARK-2951 is fixed.
- Fix MLlib _deserialize_double on Python 2.6.

Closes apache#1868.  Closes apache#1042.

Author: Josh Rosen <[email protected]>

Closes apache#1874 from JoshRosen/python2.6 and squashes the following commits:

983d259 [Josh Rosen] [SPARK-2954] Fix MLlib _deserialize_double on Python 2.6.
5d18fd7 [Josh Rosen] [SPARK-2948] [SPARK-2910] [SPARK-2101] Python 2.6 fixes
@JoshRosen JoshRosen mentioned this pull request Dec 10, 2014
Closed
davies pushed a commit to davies/spark that referenced this pull request Dec 10, 2014
@JoshRosen
[PySpark] [SPARK-2954] [SPARK-2948] [SPARK-2910] [SPARK-2101] Python …
14ad3d9 
…2.6 Fixes

- Modify python/run-tests to test with Python 2.6
- Use unittest2 when running on Python 2.6.
- Fix issue with namedtuple.
- Skip TestOutputFormat.test_newhadoop on Python 2.6 until SPARK-2951 is fixed.
- Fix MLlib _deserialize_double on Python 2.6.

Closes apache#1868.  Closes apache#1042.

Author: Josh Rosen <[email protected]>

Closes apache#1874 from JoshRosen/python2.6 and squashes the following commits:

983d259 [Josh Rosen] [SPARK-2954] Fix MLlib _deserialize_double on Python 2.6.
5d18fd7 [Josh Rosen] [SPARK-2948] [SPARK-2910] [SPARK-2101] Python 2.6 fixes

Conflicts:
	python/pyspark/mllib/_common.py
	python/pyspark/serializers.py
	python/pyspark/tests.py
szehon-ho pushed a commit to szehon-ho/spark that referenced this pull request Feb 7, 2024
@sunchao
rdar://117948760 Bump Boson version to 0.3.22 (apache#1874)
15339ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JoshRosen @SparkQA @mateiz