[SPARK-21790][TESTS] Fix Docker-based Integration Test errors. #19000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
approved these changes
Aug 19, 2017
|
Test build #80872 has finished for PR 19000 at commit
|
gatorsmile
approved these changes
Aug 19, 2017
Member
gatorsmile
left a comment
gatorsmile
left a comment
There was a problem hiding this comment.
Just ran the docker test in my local environment. It works well.
Member
|
LGTM |
Member
|
Thanks! Merging to master. |
gatorsmile
reviewed
Aug 19, 2017
| // The "PushedFilters" part should be exist in Datafrome's | ||
| // physical plan and the existence of right literals in | ||
| // "PushedFilters" is used to prove that the predicates | ||
| // pushing down have been effective. |
Member
There was a problem hiding this comment.
Since you removed the checking for the filter pushdown verification, please add them back in the follow-up PR. Thanks!
asfgit
pushed a commit
that referenced
this pull request
Aug 21, 2017
## What changes were proposed in this pull request? The previous PR(#19000) removed filter pushdown verification, This PR add them back. ## How was this patch tested? manual tests Author: Yuming Wang <[email protected]> Closes #19002 from wangyum/SPARK-21790-follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-17701 removed
metadatafunction, this PR removed the Docker-based Integration module that has been relevant toSparkPlan.metadata.How was this patch tested?
manual tests