[SPARK-21790][TESTS][FOLLOW-UP] Add filter pushdown verification back. #19002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyum
commented
Aug 20, 2017
| import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan | ||
| import org.apache.spark.sql.catalyst.util._ | ||
| import org.apache.spark.sql.execution.FilterExec | ||
| import org.apache.spark.sql.internal.SQLConf |
Member
There was a problem hiding this comment.
But I guess it's unrelated change. It wouldn't block this PR but I guess it's good to revert this one back.
|
Test build #80880 has finished for PR 19002 at commit
|
gatorsmile
reviewed
Aug 20, 2017
| assert(parentPlan.isInstanceOf[WholeStageCodegenExec]) | ||
| val node = parentPlan.asInstanceOf[WholeStageCodegenExec] | ||
| val metadata = node.child.asInstanceOf[RowDataSourceScanExec].metadata | ||
| // The "PushedFilters" part should be exist in Datafrome's |
Member
|
LGTM except a minor comment. |
|
Test build #80886 has finished for PR 19002 at commit
|
Member
Author
|
retest this please |
|
Test build #80890 has finished for PR 19002 at commit
|
HyukjinKwon
reviewed
Aug 21, 2017
| assert(parentPlan.isInstanceOf[WholeStageCodegenExec]) | ||
| val node = parentPlan.asInstanceOf[WholeStageCodegenExec] | ||
| val metadata = node.child.asInstanceOf[RowDataSourceScanExec].metadata | ||
| // The "PushedFilters" part should be exist in Dataframe's |
Member
There was a problem hiding this comment.
little nit: should be exist -> should exist
| // physical plan and the existence of right literals in | ||
| // "PushedFilters" is used to prove that the predicates | ||
| // pushing down have been effective. | ||
| assert(metadata.get("PushedFilters").ne(None)) |
Member
There was a problem hiding this comment.
nit: Could we use isDefined instead of ne(None)?
|
Test build #80919 has finished for PR 19002 at commit
|
Member
Author
|
retest this please |
|
Test build #80921 has finished for PR 19002 at commit
|
Member
|
Thanks! Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The previous PR(#19000) removed filter pushdown verification, This PR add them back.
How was this patch tested?
manual tests