[ML][MINOR] Make sharedParams update. #19011
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanboliang
commented
Aug 21, 2017
| } | ||
|
|
||
| /** | ||
| * Trait for shared param threshold (default: 0.5). |
Contributor
Author
There was a problem hiding this comment.
The definition in SharedParamsCodeGen has no default value yet, since both LogisticRegression and LinearSVC extends from HasThreshold, but they have different default value.
ParamDesc[Double]("threshold",
"threshold in binary classification prediction, in range [0, 1]",
isValid = "ParamValidators.inRange(0, 1)", finalMethods = false, finalFields = false),
|
Test build #80929 has finished for PR 19011 at commit
|
Contributor
Author
|
Merged into master. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
sharedParams.scalawas generated bySharedParamsCodeGen, but it's not updated in master. Maybe someone manual updatesharedParams.scala, this PR fix this issue.How was this patch tested?
Offline check.