Skip to content

[ML][MINOR] Make sharedParams update. #19011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yanboliang wants to merge 1 commit into from
Closed

[ML][MINOR] Make sharedParams update. #19011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ private[ml] trait HasVarianceCol extends Params {
}

/**
* Trait for shared param threshold (default: 0.5).
Copy link
Contributor Author

@yanboliang yanboliang Aug 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition in SharedParamsCodeGen has no default value yet, since both LogisticRegression and LinearSVC extends from HasThreshold, but they have different default value.

ParamDesc[Double]("threshold",
        "threshold in binary classification prediction, in range [0, 1]",
        isValid = "ParamValidators.inRange(0, 1)", finalMethods = false, finalFields = false),

* Trait for shared param threshold.
*/
private[ml] trait HasThreshold extends Params {

Expand Down