-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-21897][PYTHON][R] Add unionByName API to DataFrame in Python and R #19105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @felixcheung and @actuaryzhang, could you take a look please? |
|
Test build #81335 has finished for PR 19105 at commit
|
|
Python side change LGTM |
|
do you mean for your example in the PR description above something different? |
felixcheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments
R/pkg/R/DataFrame.R
Outdated
| union(x, y) | ||
| }) | ||
|
|
||
| #' Return a new SparkDataFrame containing the union of rows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd suggest a slight different in the title - this one is the same words as union
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I just addressed both comments.
R/pkg/R/DataFrame.R
Outdated
| #' | ||
| #' Return a new SparkDataFrame containing the union of rows in this SparkDataFrame | ||
| #' and another SparkDataFrame. This is different from both \code{UNION ALL} and | ||
| #' \code{UNION DISTINCT} in SQL as column positions are not taken into account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd list union() here too
|
Oh, yea. I made a mistake during copying and pasting the example in the description. I just corrected it. |
|
Test build #81341 has finished for PR 19105 at commit
|
|
Thank you @viirya and @felixcheung. |
|
Merged to master. |
What changes were proposed in this pull request?
This PR proposes to add a wrapper for
unionByNameAPI to R and Python as well.Python
R
How was this patch tested?
Doctests for Python and unit test added in
test_sparkSQL.Rfor R.