Skip to content

[Spark-21854] Added LogisticRegressionTrainingSummary for MultinomialLogisticRegression in Python API #19185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmwdpk wants to merge 7 commits into from
Closed

[Spark-21854] Added LogisticRegressionTrainingSummary for MultinomialLogisticRegression in Python API #19185

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
50cfafe
added probabilityCol to LogisticRegressionSummary
Sep 4, 2017
60579d5
modified LogisticRegressionSummary and LogisticRegressionModel in cla…
Sep 5, 2017
1a73e6c
test on multiclass summary
Sep 7, 2017
53ac68e
fixed numClasses
Sep 8, 2017
a4755d7
0911 added more test and simplified summary logic
jmwdpk Sep 11, 2017
eb8f6b4
added more scala unit tests for binary summary, and additional tests …
jmwdpk Sep 12, 2017
6529fa6
removed extra summary test
jmwdpk Sep 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed numClasses
  • Loading branch information
@jmwdpk
Ming Jiang authored and jmwdpk committed Sep 11, 2017
commit 53ac68e24731e405d44d50be70b1c25f2ab9df3d
3 changes: 1 addition & 2 deletions python/pyspark/ml/classification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,8 +529,7 @@ def summary(self):
"""
if self.hasSummary:
java_blrt_summary = self._call_java("summary")
Copy link
Contributor

@yanboliang yanboliang Sep 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this to java_lrt_summary, as it's not always binary logistic regression.

java_blrt_numClasses = self._call_java("numClasses")
if (java_blrt_numClasses == 2):
if (self.numClasses == 2):
Copy link
Contributor

@yanboliang yanboliang Sep 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (self.numClasses <= 2)

java_blrt_binarysummary = self._call_java("binarySummary")
Copy link
Contributor

@yanboliang yanboliang Sep 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is not necessary, we can just wrap java_lrt_summary with BinaryLogisticRegressionTrainingSummary.

return BinaryLogisticRegressionTrainingSummary(java_blrt_binarysummary)
else:
Expand Down