Skip to content

[SPARK-22651][PYTHON][ML] Prevent initiating multiple Hive clients for ImageSchema.readImages #19845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 3 commits into from
Closed

[SPARK-22651][PYTHON][ML] Prevent initiating multiple Hive clients for ImageSchema.readImages #19845

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0c3c48
Prevent initiating multiple Hive clients for ImageSchema.readImages
HyukjinKwon Nov 29, 2017
2e4c402
Add a test case
HyukjinKwon Nov 30, 2017
0c7e537
Address comments
HyukjinKwon Dec 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address comments
  • Loading branch information
@HyukjinKwon
HyukjinKwon committed Dec 1, 2017
commit 0c7e5378a491f01b14df23fe56ae50a0f52971ee
6 changes: 6 additions & 0 deletions python/pyspark/ml/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1842,6 +1842,7 @@ class ImageReaderTest2(PySparkTestCase):
@classmethod
def setUpClass(cls):
PySparkTestCase.setUpClass()
# Note that here we enable Hive's support.
try:
cls.sc._jvm.org.apache.hadoop.hive.conf.HiveConf()
except py4j.protocol.Py4JError:
Expand All @@ -1852,6 +1853,11 @@ def setUpClass(cls):
raise unittest.SkipTest("Hive is not available")
cls.spark = HiveContext._createForTesting(cls.sc)

Copy link
Member

@viirya viirya Dec 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add classmethod tearDownClass to stop the cls.spark? I didn't see HiveContextSQLTests closes it anyway, maybe we can fix it too.

Copy link
Member Author

@HyukjinKwon HyukjinKwon Dec 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that should be safer but let me fix it this one here only for now. Let's fix that up too when we touch some codes around there.

@classmethod
def tearDownClass(cls):
PySparkTestCase.tearDownClass()
cls.spark.sparkSession.stop()

def test_read_images_multiple_times(self):
# This test case is to check if `ImageSchema.readImages` tries to
# initiate Hive client multiple times. See SPARK-22651.
Expand Down