Skip to content

[SPARK-22651][PYTHON][ML] Prevent initiating multiple Hive clients for ImageSchema.readImages #19845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 3 commits into from
Closed

[SPARK-22651][PYTHON][ML] Prevent initiating multiple Hive clients for ImageSchema.readImages #19845

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0c3c48
Prevent initiating multiple Hive clients for ImageSchema.readImages
HyukjinKwon Nov 29, 2017
2e4c402
Add a test case
HyukjinKwon Nov 30, 2017
0c7e537
Address comments
HyukjinKwon Dec 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Prevent initiating multiple Hive clients for ImageSchema.readImages
  • Loading branch information
@HyukjinKwon
HyukjinKwon committed Nov 29, 2017
commit c0c3c487474629df00ba50c5b6904552010f1aab
5 changes: 2 additions & 3 deletions python/pyspark/ml/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,8 @@ def readImages(self, path, recursive=False, numPartitions=-1,
.. versionadded:: 2.3.0
"""

ctx = SparkContext._active_spark_context
spark = SparkSession(ctx)
image_schema = ctx._jvm.org.apache.spark.ml.image.ImageSchema
spark = SparkSession.builder.getOrCreate()
Copy link
Member

@viirya viirya Nov 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this should be best practice to initialize SparkSession.

image_schema = spark._jvm.org.apache.spark.ml.image.ImageSchema
jsession = spark._jsparkSession
jresult = image_schema.readImages(path, jsession, recursive, numPartitions,
dropImageFailures, float(sampleRatio), seed)
Expand Down