Skip to content

[SPARK-22938] Assert that SQLConf.get is accessed only on the driver. #20136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juliuszsompolski wants to merge 4 commits into from
Closed

[SPARK-22938] Assert that SQLConf.get is accessed only on the driver. #20136

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2b3bc6
[SPARK-22938] Assert that SQLConf.get is accessed only on the driver.
juliuszsompolski Dec 14, 2017
d5ecab9
remarks
juliuszsompolski Jan 2, 2018
43ecd30
try putting it in SQLConf constructor
juliuszsompolski Jan 2, 2018
1ecb766
assert msg
juliuszsompolski Jan 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import scala.util.matching.Regex

import org.apache.hadoop.fs.Path

import org.apache.spark.{SparkContext, SparkEnv}
import org.apache.spark.internal.Logging
import org.apache.spark.internal.config._
import org.apache.spark.network.util.ByteUnit
Expand Down Expand Up @@ -70,7 +71,10 @@ object SQLConf {
* Default config. Only used when there is no active SparkSession for the thread.
* See [[get]] for more information.
*/
private val fallbackConf = new ThreadLocal[SQLConf] {
private lazy val fallbackConf = new ThreadLocal[SQLConf] {
Copy link
Contributor

@cloud-fan cloud-fan Jan 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it have to be lazy val?

Copy link
Contributor Author

@juliuszsompolski juliuszsompolski Jan 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I checked (which was before I moved the assertion from here to SQLConf constructor, but it shouldn't matter), not having it as lazy resulted in it being instantiated eagerly as a static member of SQLConf object before SparkEnv was set and hitting the null on SparkEnv.

Copy link
Contributor

@cloud-fan cloud-fan Jan 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah i see, makes sense

// assert that we're only accessing it on the driver.
assert(SparkEnv.get.executorId == SparkContext.DRIVER_IDENTIFIER)
Copy link
Member

@maropu maropu Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need null checks for SparkEnv?

Copy link
Member

@maropu maropu Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can we check this only in test phases?


override def initialValue: SQLConf = new SQLConf
}

Expand Down