Skip to content

[SPARK-22954][SQL] Fix the exception thrown by Analyze command on temporary views to throw AnalysisException #20177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 7 commits into from
Closed

[SPARK-22954][SQL] Fix the exception thrown by Analyze command on temporary views to throw AnalysisException #20177

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8e92e6c
[SPARK-22954][SQL] Fixed the problem where temporary views were not l…
su225 Jan 5, 2018
4de6ac8
[SPARK-22954][SQL] Fixed database name lookup so that None is returne…
su225 Jan 6, 2018
98b8711
[SPARK-22954][SQL] Fixed the test to test for AnalysisException inste…
su225 Jan 7, 2018
0e873e5
[SPARK-22954][SQL] Fix the problem for other versions of analyze comm…
su225 Jan 21, 2018
77e4d6d
[SPARK-22954][SQL] Reorganize imports to satisfy Scalastyle.
su225 Jan 21, 2018
4d4e3fe
[SPARK-22954][SQL] Removed some extraneous whitespace.
su225 Jan 21, 2018
4c86456
[SPARK-22954][SQL] Add test case to make sure that calling analyze pa…
su225 Jan 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[SPARK-22954][SQL] Fixed the test to test for AnalysisException inste… 
…ad of NoSuchTableException
  • Loading branch information
@su225
su225 committed Jan 7, 2018
commit 98b8711cdd26c25fd774f77f46fc9e395ee2cffe
13 changes: 10 additions & 3 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ package org.apache.spark.sql.execution
import org.apache.spark.sql._
import org.apache.spark.sql.catalyst.TableIdentifier
import org.apache.spark.sql.catalyst.analysis.NoSuchTableException
import org.apache.spark.sql.AnalysisException
import org.apache.spark.sql.test.{SharedSQLContext, SQLTestUtils}

class SimpleSQLViewSuite extends SQLViewSuite with SharedSQLContext
Expand Down Expand Up @@ -154,11 +155,17 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
assertNoSuchTable(s"TRUNCATE TABLE $viewName")
assertNoSuchTable(s"SHOW CREATE TABLE $viewName")
assertNoSuchTable(s"SHOW PARTITIONS $viewName")
assertNoSuchTable(s"ANALYZE TABLE $viewName COMPUTE STATISTICS")
assertNoSuchTable(s"ANALYZE TABLE $viewName COMPUTE STATISTICS FOR COLUMNS id")
assertAnalysisException(s"ANALYZE TABLE $viewName COMPUTE STATISTICS")
Copy link
Contributor

@jiangxb1987 jiangxb1987 Jan 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also check the error message to ensure the AnalysisException is not thrown from elsewhere.

assertAnalysisException(s"ANALYZE TABLE $viewName COMPUTE STATISTICS FOR COLUMNS id")
}
}


private def assertAnalysisException(query: String): Unit = {
intercept[AnalysisException] {
sql(query)
}
}

private def assertNoSuchTable(query: String): Unit = {
intercept[NoSuchTableException] {
sql(query)
Expand Down