[SPARK-22954][SQL] Fix the exception thrown by Analyze command on temporary views to throw AnalysisException

[ghost]

What changes were proposed in this pull request?

Previously running ANALYZE on temporary views produced NoSuchTableException even though the view was present. It is misleading. So it has to be changed to throw AnalysisException since it comes in the analysis part.

How was this patch tested?

Some unit tests were fixed to intercept AnalysisException instead of NoSuchTableException.

[cloud-fan]

ok to test

[cloud-fan]

what's the error message after this patch?

[SparkQA]

Test build #85781 has finished for PR 20177 at commit 98b8711.

• This patch fails Scala style tests.
• This patch merges cleanly.
• This patch adds no public classes.

[ghost]

The error message after the patch:
AnalysisException: ANALYZE TABLE is not supported on views

scala> sql("ANALYZE TABLE names COMPUTE STATISTICS")

org.apache.spark.sql.AnalysisException: ANALYZE TABLE is not supported on views.;
  at org.apache.spark.sql.execution.command.AnalyzeTableCommand.run(AnalyzeTableCommand.scala:38)
  at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult$lzycompute(commands.scala:70)
  at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult(commands.scala:68)
  at org.apache.spark.sql.execution.command.ExecutedCommandExec.executeCollect(commands.scala:79)
  at org.apache.spark.sql.Dataset$$anonfun$6.apply(Dataset.scala:186)
  at org.apache.spark.sql.Dataset$$anonfun$6.apply(Dataset.scala:186)
  at org.apache.spark.sql.Dataset$$anonfun$51.apply(Dataset.scala:3243)
  at org.apache.spark.sql.execution.SQLExecution$.withNewExecutionId(SQLExecution.scala:77)
  at org.apache.spark.sql.Dataset.withAction(Dataset.scala:3242)
  at org.apache.spark.sql.Dataset.<init>(Dataset.scala:186)
  at org.apache.spark.sql.Dataset$.ofRows(Dataset.scala:71)
  at org.apache.spark.sql.SparkSession.sql(SparkSession.scala:638)

[cloud-fan]

can you fix the test?

[jiangxb1987]

We should also check the error message to ensure the AnalysisException is not thrown from elsewhere.

[jiangxb1987]

We shall also update AnalyzePartitionCommand and AnalyzeColumnCommand.

[SparkQA]

Test build #86424 has finished for PR 20177 at commit 0e873e5.

• This patch fails Scala style tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #86425 has finished for PR 20177 at commit 77e4d6d.

• This patch fails Scala style tests.
• This patch merges cleanly.
• This patch adds no public classes.

[ghost]

I updated AnalyzePartitionCommand and AnalyzeColumnCommand. I noticed another one - According to SQLViewSuite, calling truncate on view must throw NoSuchTable, where as in TruncateTableCommand class I noticed this

    if (table.tableType == CatalogTableType.VIEW) {
      throw new AnalysisException(
        s"Operation not allowed: TRUNCATE TABLE on views: $tableIdentWithDB")
    }

A bug?

[SparkQA]

Test build #86426 has finished for PR 20177 at commit 4d4e3fe.

• This patch fails due to an unknown error code, -9.
• This patch merges cleanly.
• This patch adds no public classes.

[cloud-fan]

actually it's not really useful to have NoSuchTableException, NoSuchFunctionException, etc. always using AnalysisException seems fine. CC @gatorsmile

[ghost]

I did't understand why the build is getting killed.

[cloud-fan]

retest this please

[SparkQA]

Test build #86506 has finished for PR 20177 at commit 4d4e3fe.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[jiangxb1987]

Could you also add test cases that cover ANALYZE PARTITION and ANALYZE COLUMN queries?

[ghost]

Done. Added test cases to cover ANALYZE PARTITION and ANALYZE COLUMN queries.

[SparkQA]

Test build #86791 has finished for PR 20177 at commit 4c86456.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[gatorsmile]

ok to test

[gatorsmile]

cc @wzhfy

[SparkQA]

Test build #90807 has finished for PR 20177 at commit 4c86456.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Can one of the admins verify this patch?