[SPARK-14023][MLlib] Make exceptions consistent regarding fields and columns #20500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling functionality from apache spark
pull latest from apache spark
Pulling functionality from apache spark
Pulling functionality from apache spark
pull request from apache/master
pull latest from apache spark
pull latest from apache spark
Pull apache spark
pull latest apache spark
Apache spark pull latest
|
Test build #87039 has finished for PR 20500 at commit
|
|
Test build #97808 has started for PR 20500 at commit |
|
Test build #97841 has started for PR 20500 at commit |
|
Build finished. Test FAILed. |
srowen
approved these changes
Dec 16, 2018
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
This seems fine to me @rekhajoshm ; if you'll rebase I'll merge it.
Member
|
I'm going to address this in #23373 |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Jan 5, 2019
…s for clarity in exceptions ## What changes were proposed in this pull request? Variation of apache#20500 I cheated by not referencing fields or columns at all as this exception propagates in contexts where both would be applicable. ## How was this patch tested? Existing tests Closes apache#23373 from srowen/SPARK-14023.2. Authored-by: Sean Owen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…s for clarity in exceptions ## What changes were proposed in this pull request? Variation of apache#20500 I cheated by not referencing fields or columns at all as this exception propagates in contexts where both would be applicable. ## How was this patch tested? Existing tests Closes apache#23373 from srowen/SPARK-14023.2. Authored-by: Sean Owen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make exceptions consistent regarding fields and columns
How was this patch tested?
Existing tests.