[SPARK-14023][CORE][SQL] Don't reference 'field' in StructField errors for clarity in exceptions #23373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is it related to |
MaxGekk
reviewed
Dec 22, 2018
| throw new IllegalArgumentException( | ||
| s"""Nonexistent field(s): ${nonExistFields.mkString(", ")}. | ||
| |Available fields: ${fieldNames.mkString(", ")}""".stripMargin) | ||
| s"""${nonExistFields.mkString(", ")} do not exist. |
Member
There was a problem hiding this comment.
nonExistFields can contain only one element, right? Maybe do/does?
|
Test build #100401 has finished for PR 23373 at commit
|
Member
Author
|
I think the issue is that these exceptions could pop up in several places, including anywhere you'd use a dataframe with columns. It probably applies to lots of places. I can change the tag here but won't matter for anything really |
srowen
changed the title
|
Test build #100404 has finished for PR 23373 at commit
|
| s"""Field "$name" does not exist. | ||
| |Available fields: ${fieldNames.mkString(", ")}""".stripMargin)) | ||
| s""""$name" does not exist. | ||
| |Available: ${fieldNames.mkString("\"", "\", \"", "\"")}""".stripMargin)) |
Member
There was a problem hiding this comment.
Can we keep the original form instead of adding additional " here?
scala> val s = org.apache.spark.sql.types.StructType.fromDDL("`\"` INT")
s: org.apache.spark.sql.types.StructType = StructType(StructField(",IntegerType,true))
scala> s("a")
java.lang.IllegalArgumentException: "a" does not exist.
Available: """
Member
Author
There was a problem hiding this comment.
Sure, I'll remove quotes around all versions of this exception.
Member
|
Mostly looks good except the additional cc @cloud-fan , @gatorsmile |
dongjoon-hyun
approved these changes
Dec 24, 2018
|
Test build #100413 has finished for PR 23373 at commit
|
Member
|
Merged to master. |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Jan 5, 2019
…s for clarity in exceptions ## What changes were proposed in this pull request? Variation of apache#20500 I cheated by not referencing fields or columns at all as this exception propagates in contexts where both would be applicable. ## How was this patch tested? Existing tests Closes apache#23373 from srowen/SPARK-14023.2. Authored-by: Sean Owen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…s for clarity in exceptions ## What changes were proposed in this pull request? Variation of apache#20500 I cheated by not referencing fields or columns at all as this exception propagates in contexts where both would be applicable. ## How was this patch tested? Existing tests Closes apache#23373 from srowen/SPARK-14023.2. Authored-by: Sean Owen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Variation of #20500
I cheated by not referencing fields or columns at all as this exception propagates in contexts where both would be applicable.
How was this patch tested?
Existing tests