Skip to content

[SPARK-23426][SQL] Use hive ORC impl and disable PPD for Spark 2.3.0 #20610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 7 commits into from
+68 −33
Closed

[SPARK-23426][SQL] Use hive ORC impl and disable PPD for Spark 2.3.0 #20610

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2d74b20
Use 'hive' for ORC
dongjoon-hyun Feb 14, 2018
93e6c7d
Disable PPD back.
dongjoon-hyun Feb 14, 2018
7ff4ccf
Add ORC section.
dongjoon-hyun Feb 14, 2018
46c8697
fix test case.
dongjoon-hyun Feb 14, 2018
2769633
Address comment.
dongjoon-hyun Feb 15, 2018
183ec21
Add `also`.
dongjoon-hyun Feb 15, 2018
19b50b1
Remove.
dongjoon-hyun Feb 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address comment.
  • Loading branch information
@dongjoon-hyun
dongjoon-hyun committed Feb 15, 2018
commit 276963369b663c99aebcde10f4329f479f43b3ea
7 changes: 6 additions & 1 deletion docs/sql-programming-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,12 @@ Configuration of Parquet can be done using the `setConf` method on `SparkSession

## ORC Files

Since Spark 2.3, Spark supports a vectorized ORC reader with a new ORC file format for ORC files. To do that, the following configurations are newly added. The vectorized reader is used for the native ORC tables (e.g., the ones created using the clause `USING ORC`) when `spark.sql.orc.impl` is set to `native` and `spark.sql.orc.enableVectorizedReader` is set to `true`. For the Hive ORC serde table (e.g., the ones created using the clause `USING HIVE OPTIONS (fileFormat 'ORC')`), the vectorized reader is used when `spark.sql.hive.convertMetastoreOrc` is set to `true`.
Since Spark 2.3, Spark supports a vectorized ORC reader with a new ORC file format for ORC files.
To do that, the following configurations are newly added. The vectorized reader is used for the
native ORC tables (e.g., the ones created using the clause `USING ORC`) when `spark.sql.orc.impl`
is set to `native` and `spark.sql.orc.enableVectorizedReader` is set to `true`. For the Hive ORC
serde tables (e.g., the ones created using the clause `USING HIVE OPTIONS (fileFormat 'ORC')`),
the vectorized reader is used when `spark.sql.hive.convertMetastoreOrc` is set to `true`.
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viirya . I split into multiple lines. Could you point out once more?

Copy link
Member

@viirya viirya Feb 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when spark.sql.hive.convertMetastoreOrc is (also) set to true?

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I see.


<table class="table">
<tr><th><b>Property Name</b></th><th><b>Default</b></th><th><b>Meaning</b></th></tr>
Expand Down
7 changes: 5 additions & 2 deletions sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,11 @@ class FileBasedDataSourceSuite extends QueryTest with SharedSQLContext with Befo
}

override def afterAll(): Unit = {
spark.sessionState.conf.unsetConf(SQLConf.ORC_IMPLEMENTATION)
super.afterAll()
try {
spark.sessionState.conf.unsetConf(SQLConf.ORC_IMPLEMENTATION)
} finally {
super.afterAll()
}
}
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Feb 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test coverage is the same.


private val allFileBasedDataSources = Seq("orc", "parquet", "csv", "json", "text")
Expand Down
7 changes: 5 additions & 2 deletions sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSinkSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,11 @@ class FileStreamSinkSuite extends StreamTest {
}

override def afterAll(): Unit = {
spark.sessionState.conf.unsetConf(SQLConf.ORC_IMPLEMENTATION)
super.afterAll()
try {
spark.sessionState.conf.unsetConf(SQLConf.ORC_IMPLEMENTATION)
} finally {
super.afterAll()
}
}

test("unpartitioned writing and batch reading") {
Expand Down
7 changes: 5 additions & 2 deletions sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,11 @@ class FileStreamSourceSuite extends FileStreamSourceTest {
}

override def afterAll(): Unit = {
spark.sessionState.conf.unsetConf(SQLConf.ORC_IMPLEMENTATION)
super.afterAll()
try {
spark.sessionState.conf.unsetConf(SQLConf.ORC_IMPLEMENTATION)
} finally {
super.afterAll()
}
}

// ============= Basic parameter exists tests ================
Expand Down