Skip to content

[SPARK-23426][SQL] Use hive ORC impl and disable PPD for Spark 2.3.0 #20610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 7 commits into from
Closed

[SPARK-23426][SQL] Use hive ORC impl and disable PPD for Spark 2.3.0 #20610

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2d74b20
Use 'hive' for ORC
dongjoon-hyun Feb 14, 2018
93e6c7d
Disable PPD back.
dongjoon-hyun Feb 14, 2018
7ff4ccf
Add ORC section.
dongjoon-hyun Feb 14, 2018
46c8697
fix test case.
dongjoon-hyun Feb 14, 2018
2769633
Address comment.
dongjoon-hyun Feb 15, 2018
183ec21
Add `also`.
dongjoon-hyun Feb 15, 2018
19b50b1
Remove.
dongjoon-hyun Feb 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use 'hive' for ORC
  • Loading branch information
@dongjoon-hyun
dongjoon-hyun committed Feb 14, 2018
commit 2d74b204b85db1ffcfb164a160e8f6f0d02d3f4b
2 changes: 1 addition & 1 deletion docs/sql-programming-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1784,7 +1784,7 @@ working with timestamps in `pandas_udf`s to get the best performance, see
<tr><th><b>Property Name</b></th><th><b>Default</b></th><th><b>Meaning</b></th></tr>
<tr>
<td><code>spark.sql.orc.impl</code></td>
<td><code>native</code></td>
<td><code>hive</code></td>
Copy link
Member

@gatorsmile gatorsmile Feb 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need this in the migration guide. Please create a new section for ORC

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Feb 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

Copy link

@raam86 raam86 Mar 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason the impl was changed back to the old implementation? this breaks spark.read.orc

<td>The name of ORC implementation. It can be one of <code>native</code> and <code>hive</code>. <code>native</code> means the native ORC support that is built on Apache ORC 1.4.1. `hive` means the ORC library in Hive 1.2.1 which is used prior to Spark 2.3.</td>
</tr>
<tr>
Expand Down
4 changes: 2 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,11 +399,11 @@ object SQLConf {

val ORC_IMPLEMENTATION = buildConf("spark.sql.orc.impl")
.doc("When native, use the native version of ORC support instead of the ORC library in Hive " +
"1.2.1. It is 'hive' by default prior to Spark 2.3.")
"1.2.1. It is 'hive' by default.")
.internal()
.stringConf
.checkValues(Set("hive", "native"))
.createWithDefault("native")
.createWithDefault("hive")
Copy link
Member

@gatorsmile gatorsmile Feb 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to disable the ORC pushdown, because the ORC reader of Hive 1.2.1 has a few bugs.

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Feb 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, we don't have a test case for that, do we? Actually, I want to have a test case for that.


val ORC_VECTORIZED_READER_ENABLED = buildConf("spark.sql.orc.enableVectorizedReader")
.doc("Enables vectorized orc decoding.")
Expand Down