Skip to content

[SPARK-23873][SQL] Use accessors in interpreted LambdaVariable #20981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 6 commits into from
Closed

[SPARK-23873][SQL] Use accessors in interpreted LambdaVariable #20981

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
35539be
Use accessors in interpreted LambdaVariable.
viirya Apr 5, 2018
2eb2bf1
Address comment.
viirya Apr 9, 2018
912c2c2
Address comment.
viirya Apr 10, 2018
54dd939
More generalize accessor. Make sure testing on all types.
viirya Apr 10, 2018
ea1b939
Merge remote-tracking branch 'upstream/master' into SPARK-23873
viirya Apr 11, 2018
5711ea1
Use added method.
viirya Apr 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use added method.
  • Loading branch information
@viirya
viirya committed Apr 11, 2018
commit 5711ea12574a67ee4e309b81c6d616e8841c4dd6
8 changes: 1 addition & 7 deletions ...alyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,18 +66,12 @@ trait ExpressionEvalHelper extends GeneratorDrivenPropertyChecks {
checkEvaluationWithOptimization(expr, catalystValue, inputRow)
}


private def getActualDataType(dt: DataType): DataType = dt match {
case u: UserDefinedType[_] => getActualDataType(u.sqlType)
case _ => dt
}

/**
* Check the equality between result of expression and expected value, it will handle
* Array[Byte], Spread[Double], MapData and Row.
*/
protected def checkResult(result: Any, expected: Any, exprDataType: DataType): Boolean = {
val dataType = getActualDataType(exprDataType)
val dataType = UserDefinedType.sqlType(exprDataType)

(result, expected) match {
case (result: Array[Byte], expected: Array[Byte]) =>
Expand Down