-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-23873][SQL] Use accessors in interpreted LambdaVariable #20981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
35539be
Use accessors in interpreted LambdaVariable.
viirya 2eb2bf1
Address comment.
viirya 912c2c2
Address comment.
viirya 54dd939
More generalize accessor. Make sure testing on all types.
viirya ea1b939
Merge remote-tracking branch 'upstream/master' into SPARK-23873
viirya 5711ea1
Use added method.
viirya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Address comment.
- Loading branch information
commit 912c2c2f954bc53be1d4b80f47ee1d2774f382f6
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,11 +65,19 @@ trait ExpressionEvalHelper extends GeneratorDrivenPropertyChecks { | |
| checkEvaluationWithOptimization(expr, catalystValue, inputRow) | ||
| } | ||
|
|
||
|
|
||
| private def getActualDataType(dt: DataType): DataType = dt match { | ||
|
||
| case u: UserDefinedType[_] => getActualDataType(u.sqlType) | ||
| case _ => dt | ||
| } | ||
|
|
||
| /** | ||
| * Check the equality between result of expression and expected value, it will handle | ||
| * Array[Byte], Spread[Double], MapData and Row. | ||
| */ | ||
| protected def checkResult(result: Any, expected: Any, dataType: DataType): Boolean = { | ||
| protected def checkResult(result: Any, expected: Any, exprDataType: DataType): Boolean = { | ||
| val dataType = getActualDataType(exprDataType) | ||
|
|
||
| (result, expected) match { | ||
| case (result: Array[Byte], expected: Array[Byte]) => | ||
| java.util.Arrays.equals(result, expected) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle
UDT?