Skip to content

[SPARK-23888][CORE] correct the comment of hasAttemptOnHost() #20998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ngone51 wants to merge 6 commits into from
Closed

[SPARK-23888][CORE] correct the comment of hasAttemptOnHost() #20998

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3584a09
add task attempt running check in hasAttemptOnHost
Ngone51 Apr 6, 2018
2ed9584
address review comments
Ngone51 Apr 11, 2018
5901728
address comments
Ngone51 Apr 12, 2018
500cc77
correct the comment
Ngone51 Apr 17, 2018
0c6f305
remove UT
Ngone51 Apr 17, 2018
e44d80b
address comment
Ngone51 Apr 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
correct the comment
  • Loading branch information
@Ngone51
Ngone51 committed Apr 17, 2018
commit 500cc77a3cf942730a625c81c7536455510d42f0
4 changes: 2 additions & 2 deletions core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,9 +287,9 @@ private[spark] class TaskSetManager(
None
}

/** Check whether a task is currently running an attempt on a given host */
/** Check whether a task once run an attempt on a given host */
Copy link
Member

@srowen srowen Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "once ran"?

Copy link
Member Author

@Ngone51 Ngone51 Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Thank you.

private def hasAttemptOnHost(taskIndex: Int, host: String): Boolean = {
taskAttempts(taskIndex).exists { info => info.running && info.host == host }
taskAttempts(taskIndex).exists(_.host == host)
}

private def isTaskBlacklistedOnExecOrNode(index: Int, execId: String, host: String): Boolean = {
Expand Down