Skip to content

[SPARK-23888][CORE] correct the comment of hasAttemptOnHost() #20998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ngone51 wants to merge 6 commits into from
Closed

[SPARK-23888][CORE] correct the comment of hasAttemptOnHost() #20998

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3584a09
add task attempt running check in hasAttemptOnHost
Ngone51 Apr 6, 2018
2ed9584
address review comments
Ngone51 Apr 11, 2018
5901728
address comments
Ngone51 Apr 12, 2018
500cc77
correct the comment
Ngone51 Apr 17, 2018
0c6f305
remove UT
Ngone51 Apr 17, 2018
e44d80b
address comment
Ngone51 Apr 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address comments
  • Loading branch information
@Ngone51
Ngone51 committed Apr 12, 2018
commit 5901728d6be8ad33e39d56006a2bc8cc02cfff38
5 changes: 2 additions & 3 deletions core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,8 +880,8 @@ class TaskSetManagerSuite extends SparkFunSuite with LocalSparkContext with Logg
assert(manager.resourceOffer("execB", "host2", ANY).get.index === 3)
}

test("SPARK-23888: speculative task should not run on a given host " +
"where another attempt is already running on") {
test("SPARK-23888: speculative task cannot run on a host with another " +
"running attempt, but can run on a host with a failed attempt.") {
sc = new SparkContext("local", "test")
sched = new FakeTaskScheduler(
sc, ("execA", "host1"), ("execB", "host2"))
Expand Down Expand Up @@ -916,7 +916,6 @@ class TaskSetManagerSuite extends SparkFunSuite with LocalSparkContext with Logg
// after a long long time, task0.0 failed, and task0.0 can not re-run since
// there's already a running copy.
clock.advance(1000)
info1.finishTime = clock.getTimeMillis()
manager.handleFailedTask(info1.taskId, TaskState.FAILED, UnknownReason)
assert(!info1.running)

Expand Down