Skip to content

[SPARK-24761][SQL] Adding of isModifiable() to RuntimeConfig #21730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 5 commits into from
Closed

[SPARK-24761][SQL] Adding of isModifiable() to RuntimeConfig #21730

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7819e6
[SQL] Is a config modifiable at runtime
MaxGekk Jul 8, 2018
b90dbf8
Adding ticket number to test's title
MaxGekk Jul 8, 2018
465a5dd
Addressing Sim's review comment
MaxGekk Jul 8, 2018
183c743
Improving the comment for new method
MaxGekk Jul 11, 2018
d0d4620
Added tests for invalid params
MaxGekk Jul 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improving the comment for new method
  • Loading branch information
@MaxGekk
MaxGekk committed Jul 11, 2018
commit 183c743782dd04a1f4ee2c889ea95f1b6fcf855f
3 changes: 3 additions & 0 deletions sql/core/src/main/scala/org/apache/spark/sql/RuntimeConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,9 @@ class RuntimeConfig private[sql](sqlConf: SQLConf = new SQLConf) {
* Indicates whether the configuration property with the given key
* is modifiable in the current session.
Copy link
Member

@gengliangwang gengliangwang Jul 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: If a key is not a valid conf, this function will still return false. Should we specify this in the comments?

Copy link
Member Author

@MaxGekk MaxGekk Jul 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added @return tag with this info.

*
* @return `true` if the configuration property is modifiable. For static SQL, Spark Core,
* invalid (not existing) and other non-modifiable configuration properties,
* the returned value is `false`.
* @since 2.4.0
*/
def isModifiable(key: String): Boolean = sqlConf.isModifiable(key)
Expand Down