Skip to content

[SPARK-24761][SQL] Adding of isModifiable() to RuntimeConfig #21730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 5 commits into from
Closed

[SPARK-24761][SQL] Adding of isModifiable() to RuntimeConfig #21730

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7819e6
[SQL] Is a config modifiable at runtime
MaxGekk Jul 8, 2018
b90dbf8
Adding ticket number to test's title
MaxGekk Jul 8, 2018
465a5dd
Addressing Sim's review comment
MaxGekk Jul 8, 2018
183c743
Improving the comment for new method
MaxGekk Jul 11, 2018
d0d4620
Added tests for invalid params
MaxGekk Jul 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added tests for invalid params
  • Loading branch information
@MaxGekk
MaxGekk committed Jul 11, 2018
commit d0d4620aa56f4d97a7899102dfeea601c2667e17
3 changes: 3 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/RuntimeConfigSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,8 @@ class RuntimeConfigSuite extends SparkFunSuite {
// Core configs
assert(!conf.isModifiable("spark.task.cpus"))
assert(!conf.isModifiable("spark.executor.cores"))
// Invalid config parameters
assert(!conf.isModifiable(""))
assert(!conf.isModifiable("invalid config parameter"))
}
}