[MINOR][SQL]Locality does not need to be implemented #23339
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #100270 has finished for PR 23339 at commit
|
Member
|
CC @ScrapCodes |
Member
|
Hi @srowen, to be honest, this comment was originally introduced by @cloud-fan in HadoopFileLinesReader. I have just replicated it, in the HadoopFileWholeTextReader, which is based on HadoopFileLinesReader. And, I do not know if the above claim is true. I can look into it more closely, later. |
cloud-fan
reviewed
Dec 20, 2018
Contributor
There was a problem hiding this comment.
maybe we should leave some comment to explain where the locality is decided.
10110346
force-pushed
the
noneededtodo
branch
from
57742ce to
8b83c24
Compare
cloud-fan
approved these changes
Dec 21, 2018
|
Test build #100354 has finished for PR 23339 at commit
|
Contributor
|
thanks, merging to master! |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Jan 5, 2019
## What changes were proposed in this pull request? `HadoopFileWholeTextReader` and `HadoopFileLinesReader` will be eventually called in `FileSourceScanExec`. In fact, locality has been implemented in `FileScanRDD`, even if we implement it in `HadoopFileWholeTextReader ` and `HadoopFileLinesReader`, it would be useless. So I think these `TODO` can be removed. ## How was this patch tested? N/A Closes apache#23339 from 10110346/noneededtodo. Authored-by: liuxian <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? `HadoopFileWholeTextReader` and `HadoopFileLinesReader` will be eventually called in `FileSourceScanExec`. In fact, locality has been implemented in `FileScanRDD`, even if we implement it in `HadoopFileWholeTextReader ` and `HadoopFileLinesReader`, it would be useless. So I think these `TODO` can be removed. ## How was this patch tested? N/A Closes apache#23339 from 10110346/noneededtodo. Authored-by: liuxian <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HadoopFileWholeTextReaderandHadoopFileLinesReaderwill be eventually called inFileSourceScanExec.In fact, locality has been implemented in
FileScanRDD, even if we implement it inHadoopFileWholeTextReaderandHadoopFileLinesReader, it would be useless.So I think these
TODOcan be removed.How was this patch tested?
N/A