Skip to content

[MINOR][SQL]Locality does not need to be implemented #23339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
10110346 wants to merge 1 commit into from
Closed

[MINOR][SQL]Locality does not need to be implemented #23339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ore/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileLinesReader.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class HadoopFileLinesReader(
new Path(new URI(file.filePath)),
file.start,
file.length,
// TODO: Implement Locality
Copy link
Contributor

@cloud-fan cloud-fan Dec 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should leave some comment to explain where the locality is decided.

Copy link
Contributor Author

@10110346 10110346 Dec 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

// The locality is decided by `getPreferredLocations` in `FileScanRDD`.
Array.empty)
val attemptId = new TaskAttemptID(new TaskID(new JobID(), TaskType.MAP, 0), 0)
val hadoopAttemptContext = new TaskAttemptContextImpl(conf, attemptId)
Expand Down
2 changes: 1 addition & 1 deletion ...src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileWholeTextReader.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class HadoopFileWholeTextReader(file: PartitionedFile, conf: Configuration)
Array(new Path(new URI(file.filePath))),
Array(file.start),
Array(file.length),
// TODO: Implement Locality
// The locality is decided by `getPreferredLocations` in `FileScanRDD`.
Array.empty[String])
val attemptId = new TaskAttemptID(new TaskID(new JobID(), TaskType.MAP, 0), 0)
val hadoopAttemptContext = new TaskAttemptContextImpl(conf, attemptId)
Expand Down