Skip to content

[SPARK-27418][SQL] Migrate Parquet to File Data Source V2 #24327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengliangwang wants to merge 4 commits into from
Closed

[SPARK-27418][SQL] Migrate Parquet to File Data Source V2 #24327

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ada227
parquet V2
gengliangwang Jun 4, 2019
b530e5f
use pushedFilters in ParquetPartitionReaderFactory
gengliangwang Jun 7, 2019
7d3a568
address comments
gengliangwang Jun 7, 2019
f658e92
address comments
gengliangwang Jun 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address comments
  • Loading branch information
@gengliangwang
gengliangwang committed Jun 7, 2019
commit 7d3a5686ea0fa41552840e8efa6aa66587367cba
6 changes: 3 additions & 3 deletions ...org/apache/spark/sql/execution/datasources/v2/parquet/ParquetPartitionReaderFactory.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,16 +176,16 @@ case class ParquetPartitionReaderFactory(
reader
}

private def createRowBaseReader(file: PartitionedFile): ParquetRecordReader[UnsafeRow] = {
buildReaderBase(file, createRowBaseReader0).asInstanceOf[ParquetRecordReader[UnsafeRow]]
private def createRowBaseReader(file: PartitionedFile): RecordReader[Void, UnsafeRow] = {
buildReaderBase(file, createRowBaseReader0)
}

private def createRowBaseReader0(
split: ParquetInputSplit,
partitionValues: InternalRow,
hadoopAttemptContext: TaskAttemptContextImpl,
pushed: Option[FilterPredicate],
convertTz: Option[TimeZone]): ParquetRecordReader[UnsafeRow] = {
convertTz: Option[TimeZone]): RecordReader[Void, UnsafeRow] = {
logDebug(s"Falling back to parquet-mr")
val taskContext = Option(TaskContext.get())
// ParquetRecordReader returns UnsafeRow
Expand Down
4 changes: 2 additions & 2 deletions ...main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetScanBuilder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ case class ParquetScanBuilder(
this.filters
}

// The actual filter push down happens in [[ParquetPartitionReaderFactory]].
// Note: for Parquet, the actual filter push down happens in [[ParquetPartitionReaderFactory]].
// It requires the Parquet physical schema to determine whether a filter is convertible.
// So here we simply mark that all the filters are pushed down.
// All filters that can be converted to Parquet are pushed down.
override def pushedFilters(): Array[Filter] = _pushedFilters

override def build(): Scan = {
Expand Down