Skip to content

[SPARK-27418][SQL] Migrate Parquet to File Data Source V2 #24327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengliangwang wants to merge 4 commits into from
Closed

[SPARK-27418][SQL] Migrate Parquet to File Data Source V2 #24327

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ada227
parquet V2
gengliangwang Jun 4, 2019
b530e5f
use pushedFilters in ParquetPartitionReaderFactory
gengliangwang Jun 7, 2019
7d3a568
address comments
gengliangwang Jun 7, 2019
f658e92
address comments
gengliangwang Jun 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use pushedFilters in ParquetPartitionReaderFactory
  • Loading branch information
@gengliangwang
gengliangwang committed Jun 7, 2019
commit b530e5f15a9698b28b76ff49f3dae45264386cc7
2 changes: 1 addition & 1 deletion ...org/apache/spark/sql/execution/datasources/v2/parquet/ParquetPartitionReaderFactory.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ import org.apache.spark.util.SerializableConfiguration
* @param dataSchema Schema of Parquet files.
* @param readDataSchema Required schema of Parquet files.
* @param partitionSchema Schema of partitions.
* @param filters Filters of the batch scan.
* @param filters Filters to be pushed down in the batch scan.
*/
case class ParquetPartitionReaderFactory(
sqlConf: SQLConf,
Expand Down
5 changes: 2 additions & 3 deletions ...re/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetScan.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ case class ParquetScan(
dataSchema: StructType,
readDataSchema: StructType,
readPartitionSchema: StructType,
filters: Array[Filter],
pushedFilters: Array[Filter],
Copy link
Member Author

@gengliangwang gengliangwang May 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pushedFilters is added here just for end-to-end test. Not sure if this is appropriate.

options: CaseInsensitiveStringMap)
extends FileScan(sparkSession, fileIndex, readDataSchema, readPartitionSchema) {
Expand Down Expand Up @@ -77,14 +76,14 @@ case class ParquetScan(
val broadcastedConf = sparkSession.sparkContext.broadcast(
new SerializableConfiguration(hadoopConf))
ParquetPartitionReaderFactory(sparkSession.sessionState.conf, broadcastedConf,
dataSchema, readDataSchema, readPartitionSchema, filters)
dataSchema, readDataSchema, readPartitionSchema, pushedFilters)
}

override def equals(obj: Any): Boolean = obj match {
case p: ParquetScan =>
fileIndex == p.fileIndex && dataSchema == p.dataSchema &&
readDataSchema == p.readDataSchema && readPartitionSchema == p.readPartitionSchema &&
options == p.options && equivalentFilters(filters, p.filters)
options == p.options && equivalentFilters(pushedFilters, p.pushedFilters)
case _ => false
}

Expand Down
2 changes: 1 addition & 1 deletion ...main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetScanBuilder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,6 @@ case class ParquetScanBuilder(

override def build(): Scan = {
ParquetScan(sparkSession, hadoopConf, fileIndex, dataSchema, readDataSchema(),
readPartitionSchema(), filters, _pushedFilters, options)
readPartitionSchema(), _pushedFilters, options)
}
}