Skip to content

Conversation

@dbaliafroozeh
Copy link
Contributor

@dbaliafroozeh dbaliafroozeh commented Aug 13, 2019

What changes were proposed in this pull request?

Introduces the collectInPlanAndSubqueries and subqueriesAll methods in QueryPlan that consider all the plans in the query plan, including the ones in nested subqueries.

How was this patch tested?

Unit test added

@dbaliafroozeh dbaliafroozeh changed the title SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan Aug 13, 2019
@hvanhovell
Copy link
Contributor

ok to test

Copy link
Contributor

@hvanhovell hvanhovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pending jenkins

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan [SPARK-28715][SQL] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan Aug 13, 2019
@dongjoon-hyun
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Aug 13, 2019

Test build #109043 has finished for PR 25433 at commit 1764d2d.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 13, 2019

Test build #109046 has finished for PR 25433 at commit e893a2d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hvanhovell
Copy link
Contributor

Merging to master. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants