[SPARK-31322][SQL] rename QueryPlan.collectInPlanAndSubqueries to collectWithSubqueries #28092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Apr 1, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (Pending Jenkins).
|
Test build #120680 has finished for PR 28092 at commit
|
dongjoon-hyun
pushed a commit
that referenced
this pull request
Apr 1, 2020
…lectWithSubqueries ### What changes were proposed in this pull request? rename `QueryPlan.collectInPlanAndSubqueries` to `collectWithSubqueries` ### Why are the changes needed? The old name is too verbose. `QueryPlan` is internal but it's the core of catalyst and we'd better make the API name clearer before we release it. ### Does this PR introduce any user-facing change? no ### How was this patch tested? N/A Closes #28092 from cloud-fan/rename. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 09f036a) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Merged to master/3.0. |
gatorsmile
reviewed
Apr 8, 2020
| * A variant of `collect`. This method not only apply the given function to all elements in this | ||
| * plan, also considering all the plans in its (nested) subqueries | ||
| */ | ||
| def collectInPlanAndSubqueries[B](f: PartialFunction[PlanType, B]): Seq[B] = |
Member
There was a problem hiding this comment.
LGTM
This internal API was added in Spark 3.0 by #25433
dongjoon-hyun
pushed a commit
that referenced
this pull request
Apr 12, 2020
…queries to collectWithSubqueries ### What changes were proposed in this pull request? Like #28092, this PR is to rename `QueryPlan.collectInPlanAndSubqueries` in AdaptiveSparkPlanHelper to `collectWithSubqueries` ### Why are the changes needed? The old name is too verbose. `QueryPlan` is internal but it's the core of catalyst and we'd better make the API name clearer before we release it. ### Does this PR introduce any user-facing change? no ### How was this patch tested? N/A Closes #28193 from gatorsmile/spark-31322. Authored-by: gatorsmile <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Apr 12, 2020
…queries to collectWithSubqueries ### What changes were proposed in this pull request? Like #28092, this PR is to rename `QueryPlan.collectInPlanAndSubqueries` in AdaptiveSparkPlanHelper to `collectWithSubqueries` ### Why are the changes needed? The old name is too verbose. `QueryPlan` is internal but it's the core of catalyst and we'd better make the API name clearer before we release it. ### Does this PR introduce any user-facing change? no ### How was this patch tested? N/A Closes #28193 from gatorsmile/spark-31322. Authored-by: gatorsmile <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit ad79ae1) Signed-off-by: Dongjoon Hyun <[email protected]>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…lectWithSubqueries ### What changes were proposed in this pull request? rename `QueryPlan.collectInPlanAndSubqueries` to `collectWithSubqueries` ### Why are the changes needed? The old name is too verbose. `QueryPlan` is internal but it's the core of catalyst and we'd better make the API name clearer before we release it. ### Does this PR introduce any user-facing change? no ### How was this patch tested? N/A Closes apache#28092 from cloud-fan/rename. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…queries to collectWithSubqueries ### What changes were proposed in this pull request? Like apache#28092, this PR is to rename `QueryPlan.collectInPlanAndSubqueries` in AdaptiveSparkPlanHelper to `collectWithSubqueries` ### Why are the changes needed? The old name is too verbose. `QueryPlan` is internal but it's the core of catalyst and we'd better make the API name clearer before we release it. ### Does this PR introduce any user-facing change? no ### How was this patch tested? N/A Closes apache#28193 from gatorsmile/spark-31322. Authored-by: gatorsmile <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
rename
QueryPlan.collectInPlanAndSubqueriestocollectWithSubqueriesWhy are the changes needed?
The old name is too verbose.
QueryPlanis internal but it's the core of catalyst and we'd better make the API name clearer before we release it.Does this PR introduce any user-facing change?
no
How was this patch tested?
N/A