Skip to content

[SPARK-29605][SQL] Optimize string to interval casting #26256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 29 commits into from
Closed

[SPARK-29605][SQL] Optimize string to interval casting #26256

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
b22f243
Generate benchmark results for JDK 8
MaxGekk Oct 24, 2019
c33710f
Generate benchmark results for JDK 11
MaxGekk Oct 24, 2019
ffa1bee
Initial implementation
MaxGekk Oct 25, 2019
a4c16a1
Add tests to IntervalUtilsSuite
MaxGekk Oct 25, 2019
f249f49
Optimize unit name matching
MaxGekk Oct 25, 2019
d077c87
Catch ArithmeticException
MaxGekk Oct 25, 2019
80f5a06
Generate benchmark results for JDK 8
MaxGekk Oct 25, 2019
479d5bd
Generate benchmark results for JDK 11
MaxGekk Oct 25, 2019
d68f41e
Merge remote-tracking branch 'remotes/origin/master' into string-to-i…
MaxGekk Oct 29, 2019
8e8e539
Merge remote-tracking branch 'remotes/origin/master' into string-to-i…
MaxGekk Nov 2, 2019
9dfb45d
Rebase on interval with days
MaxGekk Nov 2, 2019
8c3fb28
Merge remote-tracking branch 'remotes/origin/master' into string-to-i…
MaxGekk Nov 6, 2019
bc006a2
Refactor IntervalUtilsSuite to check fromString and stringToInterval
MaxGekk Nov 6, 2019
7515981
Bug fix: expect space after interval
MaxGekk Nov 6, 2019
78a2e8e
Use checkFromInvalidString
MaxGekk Nov 6, 2019
f61e6f8
Improve the multiple units test
MaxGekk Nov 6, 2019
dd8f2d1
Add a few units to the test
MaxGekk Nov 6, 2019
1204656
Return CalendarInterval from stringToInterval()
MaxGekk Nov 6, 2019
a2d91c3
Support fraction of seconds
MaxGekk Nov 6, 2019
94bd39b
Fix for negative values
MaxGekk Nov 6, 2019
98dd44f
Checks only second can have fractions
MaxGekk Nov 6, 2019
0cd7e88
Regen benchmark results for JDK 8
MaxGekk Nov 6, 2019
107d16c
Regen benchmark results for JDK 11
MaxGekk Nov 6, 2019
8dd9518
Address Wenchen's comments + change behavior for fractions
MaxGekk Nov 6, 2019
464eacc
Improve comments
MaxGekk Nov 6, 2019
dbad971
Unify structure
MaxGekk Nov 6, 2019
527b00e
Remove exact functions in fraction parsing
MaxGekk Nov 6, 2019
5e96a0e
Replace magic numbers
MaxGekk Nov 6, 2019
2222f13
Replace 100000000 by NANOS_PER_SECOND / 10
MaxGekk Nov 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Generate benchmark results for JDK 8
  • Loading branch information
@MaxGekk
MaxGekk committed Oct 25, 2019
commit 80f5a06635986d4202f4840755ffa00384d145ad
40 changes: 20 additions & 20 deletions sql/core/benchmarks/IntervalBenchmark-results.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,24 @@ Java HotSpot(TM) 64-Bit Server VM 1.8.0_231-b11 on Mac OS X 10.15
Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz
cast strings to intervals: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
prepare string w/ interval 465 483 20 2.1 465.5 1.0X
prepare string w/o interval 401 411 11 2.5 401.3 1.2X
1 units w/ interval 5312 5355 37 0.2 5311.8 0.1X
1 units w/o interval 5090 5140 83 0.2 5090.3 0.1X
2 units w/ interval 6491 6593 89 0.2 6491.4 0.1X
2 units w/o interval 6396 6421 22 0.2 6396.3 0.1X
3 units w/ interval 7642 7706 73 0.1 7642.4 0.1X
3 units w/o interval 7451 7521 71 0.1 7450.9 0.1X
4 units w/ interval 8704 8765 58 0.1 8703.8 0.1X
4 units w/o interval 8566 8606 39 0.1 8565.8 0.1X
5 units w/ interval 9885 9895 13 0.1 9885.3 0.0X
5 units w/o interval 9710 9718 9 0.1 9710.2 0.0X
6 units w/ interval 11242 11360 104 0.1 11241.5 0.0X
6 units w/o interval 10316 10357 36 0.1 10316.0 0.0X
7 units w/ interval 11647 11680 29 0.1 11646.9 0.0X
7 units w/o interval 11372 11376 6 0.1 11372.5 0.0X
8 units w/ interval 12845 12878 30 0.1 12844.9 0.0X
8 units w/o interval 12650 12660 14 0.1 12649.6 0.0X
9 units w/ interval 14004 14125 116 0.1 14003.6 0.0X
9 units w/o interval 13785 14056 290 0.1 13784.9 0.0X
prepare string w/ interval 396 426 27 2.5 396.3 1.0X
prepare string w/o interval 367 376 11 2.7 366.8 1.1X
1 units w/ interval 426 434 11 2.3 425.7 0.9X
1 units w/o interval 380 386 5 2.6 380.3 1.0X
2 units w/ interval 536 538 2 1.9 536.3 0.7X
2 units w/o interval 506 509 3 2.0 505.9 0.8X
3 units w/ interval 653 658 9 1.5 652.8 0.6X
3 units w/o interval 632 632 1 1.6 631.6 0.6X
4 units w/ interval 757 759 4 1.3 756.9 0.5X
4 units w/o interval 738 741 4 1.4 738.0 0.5X
5 units w/ interval 891 894 2 1.1 891.1 0.4X
5 units w/o interval 872 879 12 1.1 871.8 0.5X
6 units w/ interval 987 994 6 1.0 987.1 0.4X
6 units w/o interval 973 976 5 1.0 972.6 0.4X
7 units w/ interval 1135 1141 5 0.9 1135.3 0.3X
7 units w/o interval 1129 1133 4 0.9 1129.0 0.4X
8 units w/ interval 1171 1177 5 0.9 1171.3 0.3X
8 units w/o interval 1155 1160 4 0.9 1155.5 0.3X
9 units w/ interval 1343 1344 1 0.7 1343.0 0.3X
9 units w/o interval 1345 1349 8 0.7 1344.6 0.3X