-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-29605][SQL] Optimize string to interval casting #26256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
b22f243
Generate benchmark results for JDK 8
MaxGekk c33710f
Generate benchmark results for JDK 11
MaxGekk ffa1bee
Initial implementation
MaxGekk a4c16a1
Add tests to IntervalUtilsSuite
MaxGekk f249f49
Optimize unit name matching
MaxGekk d077c87
Catch ArithmeticException
MaxGekk 80f5a06
Generate benchmark results for JDK 8
MaxGekk 479d5bd
Generate benchmark results for JDK 11
MaxGekk d68f41e
Merge remote-tracking branch 'remotes/origin/master' into string-to-i…
MaxGekk 8e8e539
Merge remote-tracking branch 'remotes/origin/master' into string-to-i…
MaxGekk 9dfb45d
Rebase on interval with days
MaxGekk 8c3fb28
Merge remote-tracking branch 'remotes/origin/master' into string-to-i…
MaxGekk bc006a2
Refactor IntervalUtilsSuite to check fromString and stringToInterval
MaxGekk 7515981
Bug fix: expect space after interval
MaxGekk 78a2e8e
Use checkFromInvalidString
MaxGekk f61e6f8
Improve the multiple units test
MaxGekk dd8f2d1
Add a few units to the test
MaxGekk 1204656
Return CalendarInterval from stringToInterval()
MaxGekk a2d91c3
Support fraction of seconds
MaxGekk 94bd39b
Fix for negative values
MaxGekk 98dd44f
Checks only second can have fractions
MaxGekk 0cd7e88
Regen benchmark results for JDK 8
MaxGekk 107d16c
Regen benchmark results for JDK 11
MaxGekk 8dd9518
Address Wenchen's comments + change behavior for fractions
MaxGekk 464eacc
Improve comments
MaxGekk dbad971
Unify structure
MaxGekk 527b00e
Remove exact functions in fraction parsing
MaxGekk 5e96a0e
Replace magic numbers
MaxGekk 2222f13
Replace 100000000 by NANOS_PER_SECOND / 10
MaxGekk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Merge remote-tracking branch 'remotes/origin/master' into string-to-i…
…nterval # Conflicts: # sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala # sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/IntervalUtilsSuite.scala
- Loading branch information
commit 8e8e5397cc4431cd366c1eb3edf22ecf84c2bf75
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we always test
stringToIntervalandsafeFromStringtogether to make sure they have the same behavior?