[SPARK-3814][SQL] Bitwise & does not work in Hive #2789
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
Author
Contributor
Author
|
Added support for Bitwise AND(&), OR(|) ,XOR(^), NOT(~) in this PR only. Please review it. |
Contributor
There was a problem hiding this comment.
Why have a default implementation here? That is just converting something that could be caught at compile time to a runtime exception.
Contributor
There was a problem hiding this comment.
Oh I see because of the other binary expressions that also override eval. We should at least leave a note by changing the Exception to "BinaryExpressions must either override eval or evalInternal".
|
Can one of the admins verify this patch? |
Contributor
|
Would you please rebase? |
Contributor
Author
|
Closed this PR as it has merge conflicts and created new PR #2926 and handled comments here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no support of Bitwise & , | in Spark HiveQl and Spark SQL as well. So this PR support the same.
I am closing #2736 as it has conflicts to merge. And I handled all review comments in that PR.
Author : ravipesala [email protected]