Skip to content

[SPARK-3814][SQL] Support for Bitwise AND(&), OR(|) ,XOR(^), NOT(~) in Spark HQL and SQL #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ravipesala wants to merge 2 commits into from
Closed

[SPARK-3814][SQL] Support for Bitwise AND(&), OR(|) ,XOR(^), NOT(~) in Spark HQL and SQL #2926

ravipesala wants to merge 2 commits into from

Conversation

@ravipesala
Copy link
Contributor

@ravipesala ravipesala commented Oct 24, 2014

Currently there is no support of Bitwise & , | in Spark HiveQl and Spark SQL as well. So this PR support the same.
I am closing #2789 as it has conflicts to merge. And also added support for Bitwise AND(&), OR(|) ,XOR(^), NOT(~) And I handled all review comments in that PR.

@AmplabJenkins
Copy link

AmplabJenkins commented Oct 24, 2014

Can one of the admins verify this patch?

@ravipesala ravipesala mentioned this pull request Oct 24, 2014
Closed
@liancheng
Copy link
Contributor

liancheng commented Oct 24, 2014

test this please

@SparkQA
Copy link

SparkQA commented Oct 24, 2014

Test build #22139 has started for PR 2926 at commit 90ebbe0.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 24, 2014

Test build #22139 has finished for PR 2926 at commit 90ebbe0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class BitwiseAnd(left: Expression, right: Expression) extends BinaryArithmetic
    • case class BitwiseOr(left: Expression, right: Expression) extends BinaryArithmetic
    • case class BitwiseXor(left: Expression, right: Expression) extends BinaryArithmetic
    • case class BitwiseNot(child: Expression) extends UnaryExpression

@AmplabJenkins
Copy link

AmplabJenkins commented Oct 24, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22139/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Oct 25, 2014

Test build #437 has started for PR 2926 at commit 90ebbe0.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 25, 2014

Test build #437 has finished for PR 2926 at commit 90ebbe0.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class BitwiseAnd(left: Expression, right: Expression) extends BinaryArithmetic
    • case class BitwiseOr(left: Expression, right: Expression) extends BinaryArithmetic
    • case class BitwiseXor(left: Expression, right: Expression) extends BinaryArithmetic
    • case class BitwiseNot(child: Expression) extends UnaryExpression

@SparkQA
Copy link

SparkQA commented Oct 26, 2014

Test build #460 has started for PR 2926 at commit 90ebbe0.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 26, 2014

Test build #467 has started for PR 2926 at commit 90ebbe0.

  • This patch does not merge cleanly.

@SparkQA
Copy link

SparkQA commented Oct 26, 2014

Test build #460 has finished for PR 2926 at commit 90ebbe0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class BitwiseAnd(left: Expression, right: Expression) extends BinaryArithmetic
    • case class BitwiseOr(left: Expression, right: Expression) extends BinaryArithmetic
    • case class BitwiseXor(left: Expression, right: Expression) extends BinaryArithmetic
    • case class BitwiseNot(child: Expression) extends UnaryExpression

@marmbrus
Copy link
Contributor

marmbrus commented Oct 26, 2014

This LGTM. Can you please merge with master and push to this branch.

@SparkQA
Copy link

SparkQA commented Oct 27, 2014

Test build #467 has finished for PR 2926 at commit 90ebbe0.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds the following public classes (experimental):
    • case class BitwiseAnd(left: Expression, right: Expression) extends BinaryArithmetic
    • case class BitwiseOr(left: Expression, right: Expression) extends BinaryArithmetic
    • case class BitwiseXor(left: Expression, right: Expression) extends BinaryArithmetic
    • case class BitwiseNot(child: Expression) extends UnaryExpression

@ravipesala ravipesala mentioned this pull request Oct 27, 2014
Closed
@ravipesala
Copy link
Contributor Author

ravipesala commented Oct 27, 2014

Closed this PR and created new PR #2961 after rebasing with master

@ravipesala ravipesala closed this Oct 27, 2014
@ravipesala ravipesala deleted the SPARK-3814-NEW3 branch October 27, 2014 18:30
asfgit pushed a commit that referenced this pull request Oct 28, 2014
@ravipesala @marmbrus
[SPARK-3814][SQL] Support for Bitwise AND(&), OR(|) ,XOR(^), NOT(~) i…
5807cb4 
…n Spark HQL and SQL

Currently there is no support of Bitwise & , | in Spark HiveQl and Spark SQL as well. So this PR support the same.
I am closing #2926 as it has conflicts to merge. And also added support for Bitwise AND(&), OR(|) ,XOR(^), NOT(~) And I handled all review comments in that PR

Author: ravipesala <[email protected]>

Closes #2961 from ravipesala/SPARK-3814-NEW4 and squashes the following commits:

a391c7a [ravipesala] Rebase with master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ravipesala @AmplabJenkins @liancheng @SparkQA @marmbrus